Keep bower_components and vendor separate. #1836
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that
import Baz from 'bower_components/foo-bar/baz';
works properly. Prior to this change you would have had to know and understand that we are internally mergingbower_components/
andvendor/
together (and therefore you would need to useimport Baz from 'vendor/foo-bar/baz';
).No fundamental functionality was lost, but it might be a breaking change for folks that were importing things that happened to be in
bower_components/
, but were usingvendor/
in the import. I'll make sure to call it out as a breaking change in the changelog.Addresses #1789, in that
app.import('bower_components/foo-bar/baz.js')
andimport Foo from 'bower_components/foo-bar/baz';
now show the proper directories in the errors that spit out.