Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ember g adapter extend from application adapter if present (closes ... #1831

Merged
merged 2 commits into from
Aug 31, 2014

Conversation

abuiles
Copy link
Member

@abuiles abuiles commented Aug 31, 2014

...[#1764]).

@abuiles abuiles force-pushed the adapter-generator-enhancement branch 2 times, most recently from ac25f54 to 12adce1 Compare August 31, 2014 14:57
@bcardarella
Copy link
Contributor

👍

@abuiles abuiles force-pushed the adapter-generator-enhancement branch from 12adce1 to 2f7a06f Compare August 31, 2014 15:00
@abuiles
Copy link
Member Author

abuiles commented Aug 31, 2014

oh, I forgot we talked about --base-class as option too, working on that.

Allows to specify a --base-class or use app/adapters/application.js if
present.

Expects base-class to be relative to /adapters.

- `ember g adapter --base-class=application`
- `ember g adapter --base-class=bar`
- `ember g adapter --base-class=foo/bar`
@abuiles
Copy link
Member Author

abuiles commented Aug 31, 2014

--base-class option added.

rwjblue added a commit that referenced this pull request Aug 31, 2014
Make ember g adapter extend from application adapter if present (closes ...
@rwjblue rwjblue merged commit 57801e8 into ember-cli:master Aug 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants