Make all environments available from modules. #1820
Conversation
| fs.mkdirSync(outputDir); | ||
| } | ||
|
|
||
| ['test', 'development', 'production'].forEach(function(env) { |
There was a problem hiding this comment.
There seems to be a lot of requests for custom environment support(ex: I use a staging environment).
This should be extendable to allow users to define other environments
There was a problem hiding this comment.
It could be added to the project's config since it's being passed in to the options
There was a problem hiding this comment.
Removed hard coded environments. Anyone using the current mechanism for adding custom environments (passing vendorFiles to EmberApp upon instantiation) will have things "just work".
rwjblue
force-pushed
the
make-all-environments-available
branch
from
eea7fe1
to
f9de2ce
Compare
Make all environments available from modules.
|
This was changed in #1827 to only export the current environment and test environment (if testing is enabled). This is to ensure we do not leak environment information (for example you wouldn't want development/staging/etc environment info in a production build). |
This is another step towards #1750. Also, will be helpful for fixing #1793 (more to come on that front in a future PR).