Clear require cache for config reloads. #1809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrapping in a `Function` worked for simple `config/environment.js` contents but breaks down in other scenarios that relied on the file being evaluated in "nodeland". The prior implementation prevented custom `require`'s (to get the package name from the `package.json` for instance). Now we just clear the `require` cache to allow re-requiring the file again.
rwjblue
force-pushed
the
properly-clear-node-cache
branch
from
bf0eb99
to
be4ccfe
Compare
rwjblue
added a commit
that referenced
this pull request
Aug 28, 2014
Clear require cache for config reloads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrapping in a
Functionworked for simpleconfig/environment.jscontents but breaks down in other scenarios that relied on the file being evaluated in "nodeland". The prior implementation prevented customrequire's (to get the package name from thepackage.jsonfor instance).Now we just clear the
requirecache to allow re-requiring the file again.Documentation of
require.cache:http://nodejs.org/api/globals.html#globals_require_cache