Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back .bowerrc file. #1761

Merged
merged 1 commit into from
Aug 26, 2014
Merged

Bring back .bowerrc file. #1761

merged 1 commit into from
Aug 26, 2014

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Aug 26, 2014

This makes upgrades much easier, and prevents issues with bower searching an applications parent directories and finding an unrelated .bowerrc file that has a directory directive.

This makes upgrades much easier, and prevents issues with bower
searching an applications parent directories and finding an unrelated
`.bowerrc` file that has a directory directive.
@abuiles
Copy link
Member

abuiles commented Aug 26, 2014

@rwjblue great idea! some people upgrading seems to get stuck with this.

@stefanpenner
Copy link
Contributor

👍

@twokul
Copy link
Contributor

twokul commented Aug 26, 2014

redundant file at this point, no?

@abuiles
Copy link
Member

abuiles commented Aug 26, 2014

@rwjblue I fire a rebuild in happy and failed again, do you know what's going on ?

@rwjblue
Copy link
Member Author

rwjblue commented Aug 26, 2014

@abuiles - Yes, the changes from #1757 are causing the build to fail. I am looking into it.

@twokul
Copy link
Contributor

twokul commented Aug 26, 2014

@abuiles related to [email protected]

@rwjblue
Copy link
Member Author

rwjblue commented Aug 26, 2014

@twokul - It is definitely not redundant. bower_components/ is the default, but if ANY parent directories of your project contain a .bowerrc then bower install will use that directory, but we do not know to use that directory so things go 💥.

@twokul
Copy link
Contributor

twokul commented Aug 26, 2014

@rwjblue ah, I see. thanks for explaining

rwjblue added a commit that referenced this pull request Aug 26, 2014
@rwjblue rwjblue merged commit 965424e into ember-cli:master Aug 26, 2014
@rwjblue rwjblue deleted the keep-bowerrc branch January 2, 2019 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants