Extracts CoreObject into a separate library. #1752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -17,12 +17,14 @@ var preprocessJs = p.preprocessJs; | |||
| var preprocessCss = p.preprocessCss; | |||
| var preprocessTemplates = p.preprocessTemplates; | |||
|
|
|||
| var CoreObject = require('core_object'); | |||
There was a problem hiding this comment.
@stefanpenner named the repo core_object. I named the package core_object.
There was a problem hiding this comment.
underscore seems odd to me considering everything else is hyphenated?
There was a problem hiding this comment.
|
@rwjblue @stefanpenner PR updated and ready to be merged in. |
|
@twokul - It also needs to be added to the bundled deps section in the |
This is a first step towards the direction of splitting `ember-cli` into micro libraries. `CoreObject` now lives under [stefanpenner/core_object](https://github.com/stefanpenner/core_object).
|
@rwjblue good catch! fixed. |
|
LGTM @stefanpenner - any last words? |
|
@rwjblue sounds like a threat to @stefanpenner |
stefanpenner
added a commit
that referenced
this pull request
Aug 26, 2014
Extracts CoreObject into a separate library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first step towards the direction of splitting
ember-cliinto micro libraries.CoreObjectnow lives under stefanpenner/core_object.