Throw an error if an Addon does not specify a name. #1741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use a generated name when an addon just uses the default implementation (meaning it doesn't need an index.js), but if you export an object that does not contain `name` you get very weird and bizarre errors (took me a bit to track it down).
rwjblue
force-pushed
the
throw-an-error-if-name-is-not-specified
branch
from
e78e019
to
b4d35e9
Compare
rwjblue
added a commit
that referenced
this pull request
Aug 26, 2014
…pecified Throw an error if an Addon does not specify a name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use a generated name when an addon just uses the default implementation (meaning it doesn't need an index.js), but if you export an object that does not contain
nameyou get very weird and bizarre errors (took me a bit to track it down).