Fix the /tests URL in IE8 #1707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IE8 does not sent a text/html header, so tests don't load unless we allow */* requests to fetch the test file.
|
👍 |
stefanpenner
added a commit
that referenced
this pull request
Aug 20, 2014
Fix the /tests URL in IE8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IE8 does not sent a text/html header, so tests don't load unless we allow / requests to fetch the test file.
This is, unfortunately, complicated by a strange proxy requirement that
*/*requests be passed through to the proxy as if they were JSON. That limits this fix to being pretty narrow, and I believe the wildcard route catcher will not work correctly in IE8.I understand that history isn't supported in IE8 anyway, but still having the request treated like other browsers are treated seems more ideal.