Don't assume bowerrc.directory value #1553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also need to change this: https://github.com/stefanpenner/ember-cli/blob/master/lib/broccoli/ember-app.js#L556 |
|
LGTM |
|
👍 (once that extra line is updated also) |
|
@bcardarella - How did this end up being attributed to me? |
|
Sorry, this is what happens when I rebase while talking on the phone |
rwjblue
added a commit
that referenced
this pull request
Aug 4, 2014
…ctory Don't assume bowerrc.directory value
quaertym
added a commit
to quaertym/ember-cli-ember-data
that referenced
this pull request
Aug 19, 2014
Since this [PR](ember-cli/ember-cli#1553), I think we should not assume bower directory is `vendor`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.