Ensure non /assets/ files can be served.
#1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, any files in `public/` (outside of `public/assets/`) would not be served up as it was assumed to match history API requests and redirect to `/index.html`. This commit fixes that, by serving up any files that exist in the built output directory before falling back to checking for history API support (and subsequently proxying).
stefanpenner
added a commit
that referenced
this pull request
Aug 3, 2014
Ensure non `/assets/` files can be served.
rwjblue
added a commit
that referenced
this pull request
Aug 4, 2014
|
Cool thanks... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, any files in
public/(outside ofpublic/assets/) would not be served up as it was assumed to match history API requests and redirect to/index.html.This commit fixes that, by serving up any files that exist in the built output directory before falling back to checking for history API support (and subsequently proxying).
Closes #1404.
This is a prerequisite for #1542.