Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update testem version, enables api proxy in testing #1539

Merged
merged 1 commit into from
Aug 1, 2014

Conversation

ghedamat
Copy link
Contributor

@ghedamat ghedamat commented Aug 1, 2014

With the latest update to testem it's now possible to run the tests and proxy to the api stubs served by ember serve adding something like this

  "proxies": {
    "/api": {
      "port": 4200,
      "host": "localhost"
    }

to testem.json

if the work on #1423 continues we won't need to have ember serve active during tests anymore

if interested see discussion at testem/testem#218 and testem/testem#391

couple of questions:

  • shall we add this to the docs within this PR?
  • shall we add tests? this is kind of external to ember-cli as all the behaviour is in testem
  • shall this be tagged as ENHANCEMENT or INTERNAL?
  • I'd love someone else to test this change in their project :)

thanks!

@rwjblue
Copy link
Member

rwjblue commented Aug 1, 2014

👍 - We should definitely be on the latest version. I'll try to make some time to review #1423 in more detail (to be able to use the proxy in integration testing and whatnot).

rwjblue added a commit that referenced this pull request Aug 1, 2014
update testem version, enables api proxy in testing
@rwjblue rwjblue merged commit 1e2e9ce into ember-cli:master Aug 1, 2014
@ghedamat
Copy link
Contributor Author

ghedamat commented Aug 1, 2014

@rwjblue sounds good, I think it's worth waiting for #1423 before documenting, but if you think otherwise just ping me here or on irc and I'll add the current behaviour to the docs.

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants