-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addons can pull in test trees #1453
Addons can pull in test trees #1453
Conversation
I am 👍 on this (it should be possible to have a test tree from an addon). I'm not really sure that an addon should be adding new tests of its own, but it should definitely be allowed to add test helpers and such (which this makes easier). |
@rwjblue correct, I don't advocate for adding tests either. Although it would now be possible, it should not be encouraged |
Hmm, so I've been building out addons with their own unit tests. Are you suggesting those should instead be written on the app in which the addon is being included? |
@jdjkelly no, this is for pulling helpers from an addon into your test suite. For example, my ember-cli-proxy-fixtures addon will need to concat onto tests.js with the proxy fixture data and loader. |
Wait, I think I misunderstood the PR. Addons can continue to have its own test - but those would not be injected into application in which the addon is included. EDIT: Got it. Thanks for the clarification. |
@jdjkelly correct, the structure of addons needs some thought for how the |
@rwjblue @stefanpenner anything holding this up? |
@bcardarella - Not sure why, but this is failing the test I added in #1522. It could just be that you need to rebase and force push (as it doesn't appear that this is changing that behavior at all). |
@rwjblue I just rebased again but I actually rebased against master last night. Not sure why its failing, Npm reports:
Never seen that before |
@bcardarella thats a trolling error if i ever saw one. |
@stefanpenner I think I found the answer, seems the failing test was in the smoke test and not regular |
Addons can pull in test trees
The use case for this is with
ember-cli-proxy-fixtures
. I need to add additional QUnit functionality to the test suite to serve up proxy fixtures. Anything intest-support/
will get pulled into the test free