Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the test env #1401

Merged
merged 2 commits into from
Jul 19, 2014
Merged

Use the test env #1401

merged 2 commits into from
Jul 19, 2014

Conversation

marcoow
Copy link
Contributor

@marcoow marcoow commented Jul 17, 2014

This runs tests with the test environment by default and adds an (empty)

if (environment === 'test') {
}

section to config/environment.js,

@stefanpenner
Copy link
Contributor

can you add a changelog entry

rwjblue added a commit that referenced this pull request Jul 19, 2014
@rwjblue rwjblue merged commit 359786a into ember-cli:master Jul 19, 2014
@dustinfarris
Copy link

Thanks for this.

@dustinfarris
Copy link

@marcoow Did you miss the added test config section in the blueprint?

@psrpinto
Copy link

This is a great addition, thanks. However, when running tests in the browser, e.g. http://0.0.0.0:4200/tests the environment is still development.

I think it would make sense to have the environment set to test when accessing /tests. Should I open an issue?

@MattMSumner
Copy link

@regularjack: try running ember test --server and go to http://localhost:7357 instead.

I think switching environment for just /tests is non trivial so if the above works that should be a better solution.

@stefanpenner
Copy link
Contributor

@MattMSumner it should be possible for us to makes /tests run in the test environment, and likely a good idea

@dustinfarris
Copy link

Possibly related to #1415

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants