Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon blueprint #1374

Merged
merged 1 commit into from
Aug 8, 2014
Merged

Addon blueprint #1374

merged 1 commit into from
Aug 8, 2014

Conversation

bcardarella
Copy link
Contributor

Generates a skeleton project for addons

@stefanpenner
Copy link
Contributor

i will review after work, thanks!

@stefanpenner
Copy link
Contributor

sorry for the delay, just reviewed and it looks great. rebase?

@bcardarella
Copy link
Contributor Author

@stefanpenner I'm going to make changes to this after #1544

@stefanpenner
Copy link
Contributor

@bcardarella keep me posted, let me know if im blocking you on anything.

@rwjblue
Copy link
Member

rwjblue commented Aug 8, 2014

Should be ready for a rebase now, then looks good to me.

}
},
files: function() {
Blueprint;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can likely be removed (my guess is that it was a debugging artifact)...

Generates a skeleton project for addons
rwjblue added a commit that referenced this pull request Aug 8, 2014
@rwjblue rwjblue merged commit 9cc65ae into ember-cli:master Aug 8, 2014
@bcardarella bcardarella deleted the bc-addon-blueprint branch August 8, 2014 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants