Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use project.root for ember generate #1165

Merged
merged 1 commit into from
Jun 26, 2014

Conversation

jgwhite
Copy link
Contributor

@jgwhite jgwhite commented Jun 26, 2014

Addresses #1153

Refactors Blueprint. Here are the details:

Refactor Blueprint Lookup:

The only default lookup path is ember-cli’s own blueprints directory.
Any other lookup paths must be passed explicitly.

Blueprint.lookup('foo', { paths: [project.blueprintsPath()] });

Refactor Blueprint Construction:

The constructor takes only the path to the blueprint directory. The
options ui, analytics and project should now be passed to
install.

var blueprint = new Blueprint('my/cool/blueprint');

blueprint.install({
  target: this.project.root,
  entity: { name: 'foo' },
  ui: this.ui,
  analytics: this.analytics,
  project: this.project
});

Addresses ember-cli#1153

Refactors Blueprint. Here are the details:

Refactor Blueprint Lookup:

The only default lookup path is ember-cli’s own blueprints directory.
Any other lookup paths must be passed explicitly.

    Blueprint.lookup('foo', { paths: [project.blueprintsPath()] });

Refactor Blueprint Construction:

The constructor takes only the path to the blueprint directory. The
options `ui`, `analytics` and `project` should now be passed to
`install`.

    var blueprint = new Blueprint('my/cool/blueprint');

    blueprint.install({
      target: this.project.root,
      entity: { name: 'foo' },
      ui: this.ui,
      analytics: this.analytics,
      project: this.project
    });
@stefanpenner
Copy link
Contributor

Awesome thanks!

stefanpenner added a commit that referenced this pull request Jun 26, 2014
Use project.root for ember generate
@stefanpenner stefanpenner merged commit 9b783cf into ember-cli:master Jun 26, 2014
@jgwhite jgwhite deleted the blueprint-root-patch branch June 26, 2014 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants