Refactor preprocessors to work with addons. #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create plugin subclasses to allow usage of inheritance, but still use custom `toTree` methods. * Make `preprocessJS` defer to the plugins `toTree` method (allows plugins to require from their own node_modules folder). * Make `preprocessTemplates` defer to the plugins `toTree` method (allows plugins to require from their own node_modules folder). These changes allow addons to add their own preprocessors during their `included` hook. Please review the following for implementation details on the addon side: * [ember-cli-esnext](https://github.com/rjackson/ember-cli-esnext/blob/master/index.js) * [sample app](rwjblue/_____ember-cli-test@4391e62)
|
|
||
| function Registry(plugins, app) { | ||
| this.registry = {}; | ||
| this.availablePlugins = plugins; | ||
| this.app = app; | ||
| this.pluginTypes = { | ||
| 'js': JavascriptPlugin, |
There was a problem hiding this comment.
i think we should aim to suppose multiple plugins per type, so people refactoring from coffee -> js can do so. My quick skim implies this isn't ?
There was a problem hiding this comment.
It is not supported by this PR, but it isn't impacted by it either (we didn't previously support it).
IMHO, I can add that as a refactoring after my round of addon stuff is done...
There was a problem hiding this comment.
Added #1033 so we don't loose track.
stefanpenner
added a commit
that referenced
this pull request
Jun 14, 2014
…sure Refactor preprocessors to work with addons.
rwjblue
added a commit
that referenced
this pull request
Jun 14, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toTreemethods.preprocessJSdefer to the pluginstoTreemethod (allows plugins to require from their own node_modules folder).preprocessTemplatesdefer to the pluginstoTreemethod (allows plugins to require from their own node_modules folder).These changes allow addons to add their own preprocessors during their
includedhook.Please review the following for implementation details on the addon side: