Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix public folder deleted breaking build #1270

Merged
merged 1 commit into from
Jul 5, 2014

Conversation

jakecraige
Copy link
Member

If the public folder is deleted, it breaks the build command.

Steps to reproduce in 0.0.39:

ember new public-deleted
cd public-deleted
rm -r public
ember build

Should throw an error like:

version: 0.0.39
Build failed.
ENOENT, no such file or directory 'public/'
Error: ENOENT, no such file or directory 'public/'
  at Object.fs.readdirSync (fs.js:654:18)
  at walkSync (/Users/jake/Work/ember-cli-cordova-auth/test-app/node_modules/ember-cli/node_modules/walk-sync/index.js:14:20)
  at /Users/jake/Work/ember-cli-cordova-auth/test-app/node_modules/ember-cli/node_modules/broccoli-merge-trees/index.js:26:26
  at tryCatch (/Users/jake/Work/ember-cli-cordova-auth/test-app/node_modules/ember-cli/node_modules/rsvp/dist/commonjs/rsvp/-internal.js:163:16)
  at invokeCallback (/Users/jake/Work/ember-cli-cordova-auth/test-app/node_modules/ember-cli/node_modules/rsvp/dist/commonjs/rsvp/-internal.js:172:17)
  at publish (/Users/jake/Work/ember-cli-cordova-auth/test-app/node_modules/ember-cli/node_modules/rsvp/dist/commonjs/rsvp/-internal.js:150:13)
  at flush (/Users/jake/Work/ember-cli-cordova-auth/test-app/node_modules/ember-cli/node_modules/rsvp/dist/commonjs/rsvp/asap.js:51:9)
  at process._tickCallback (node.js:415:13)

jakecraige added a commit to poetic/ember-cli-cordova-auth that referenced this pull request Jul 4, 2014
@rwjblue
Copy link
Member

rwjblue commented Jul 5, 2014

LGTM

rwjblue added a commit that referenced this pull request Jul 5, 2014
fix public folder deleted breaking build
@rwjblue rwjblue merged commit c6e5f36 into ember-cli:master Jul 5, 2014
@jakecraige jakecraige deleted the public_folder_not_exist branch July 5, 2014 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants