Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct uname flag for setting arch #15

Merged
merged 1 commit into from
Dec 24, 2019

Conversation

ddlees
Copy link
Contributor

@ddlees ddlees commented Dec 23, 2019

Resolves #14

@stefanmaric stefanmaric changed the base branch from master to next December 24, 2019 10:16
@stefanmaric
Copy link
Owner

@ddlees, thanks! Good catch!

I'm just curious: I installed coreutils in macos via brew and the conflicting binaries got a g prefix, so the coreutils' uname was available as guname instead. How does a regular macos user (which I'm not) gets their system uname replaced by coreutils' one?

@stefanmaric stefanmaric merged commit 6e1be10 into stefanmaric:next Dec 24, 2019
stefanmaric added a commit that referenced this pull request Dec 24, 2019
- Fix arch detection bug in MacOS with coreutils (#15, thanks @ddlees)
- Document decisions around architecture detection
- Add support for arm64, ppc64l, and s390x arch detection
@ddlees
Copy link
Contributor Author

ddlees commented Dec 24, 2019

@ddlees, thanks! Good catch!

I'm just curious: I installed coreutils in macos via brew and the conflicting binaries got a g prefix, so the coreutils' uname was available as guname instead. How does a regular macos user (which I'm not) gets their system uname replaced by coreutils' one?

Always happy to help 😄 . To use the coreutils with their real names you just need to prefix PATH and MANPATH to overide the system builtins. Here's what mine looks like in my .zshrc:

PATH="/usr/local/opt/coreutils/libexec/gnubin:$PATH"
MANPATH="/usr/local/opt/coreutils/libexec/gnuman:$MANPATH"

Thanks for getting to this so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants