Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global meteor.json #26

Closed
gerstorfer opened this issue Mar 19, 2024 · 5 comments · Fixed by #27
Closed

Global meteor.json #26

gerstorfer opened this issue Mar 19, 2024 · 5 comments · Fixed by #27
Labels
bug Something isn't working

Comments

@gerstorfer
Copy link

gerstorfer commented Mar 19, 2024

🐛 Describe the bug

The config file .meteor.json is not found when placed in $HOME. Everything works as expected, when .meteor.json is placed above the working dir (even deeply nested) until the uppermost dir is the home directory.

It would be nice to have a global configuration in ~/.meteor.json and/or ~/.config/meteor.json and/or ~/.config/meteor/meteor.json

Versions

meteor version 0.18.0

@gerstorfer gerstorfer added the bug Something isn't working label Mar 19, 2024
@stefanlogue
Copy link
Owner

stefanlogue commented Mar 19, 2024

Nice catch! I think I know what's causing the issue and will release a fixed version as soon as I have some time.

In regards to having multiple places for the global configuration, it becomes a bit more tricky. If a user has the config file at each of those locations, which takes priority? I've solved this locally by symlinking all of my dotfiles to the $HOME directory

@gerstorfer
Copy link
Author

Great! Looking forward to it.

@sebastianwebber
Copy link
Contributor

@stefanlogue @gerstorfer i proposed a PR that solves this specific issue.

@stefanlogue
Copy link
Owner

Big thanks to @sebastianwebber for the fix! It's now released in v0.19!

@gerstorfer
Copy link
Author

Thank you @sebastianwebber for the PR and @stefanlogue for releasing the fix so quickly! Very much appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants