Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to filter images #34

Closed
wants to merge 2 commits into from
Closed

Add ability to filter images #34

wants to merge 2 commits into from

Conversation

danielhusar
Copy link
Collaborator

Hey, I have added ability to show only modified screenshots :)
Currently it works only for canvas, as image magic is little more complicated (maybe crate some json with changes there ?)

This is how it looks like:
screen shot 2015-01-20 at 11 58 48

Partially fixes: #32

@stefanjudis what you think ?

@stefanjudis
Copy link
Owner

Loving it. :)

But would also only go with it, when it's supported for all options.
As far as I know imagemagick can also evaluate number of different pixels and stuff. :)

Please think of the spaces coding-style. :)
Sorry, but consistent style is really important to me. :bowtie:

@danielhusar
Copy link
Collaborator Author

Ah sorry, I usually don't pay attention to spaces/tabs as editor config solve this, will fix it.

Ok I will try to came with something for the image magic as well.

@stefanjudis
Copy link
Owner

Great!

yeah - editor config is not looking for spaces regarding coding style isn't it? JSCS is a nice thing, I've got included in different projects.

We might also think of putting it in here.

Thanks. :)

@stefanjudis
Copy link
Owner

@danielhusar

Do we want to finish this one day? No pressure, but if not I'll close the PR.

@danielhusar
Copy link
Collaborator Author

Hey,

Yeah I hope so :)
I'm usually quite busy at my job but I will try to do it next time I have some time off :)

@stefanjudis
Copy link
Owner

Ja, no pressure. :)

Just wanted to check, because I also have rarely time.

@stefanjudis
Copy link
Owner

Closing due to inactivity.

@sbmadhav
Copy link
Contributor

was this merged to master ? How to configure threshold ?

@stefanjudis
Copy link
Owner

@sbmadhav Nope - was not finished due to inactivity. Sorry.

@sbmadhav
Copy link
Contributor

Let me see if I can contribute to this. No commitments yet. But this is something I need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only show screenshots when there are differences (optional)
3 participants