Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there an option to make the calendar Right-to-Left? to support rtl languages #126

Closed
Abdox3 opened this issue Oct 4, 2018 · 12 comments
Closed

Comments

@Abdox3
Copy link

Abdox3 commented Oct 4, 2018

No description provided.

@stefangabos
Copy link
Owner

Sorry, my experience with rtl languages is close to none so I don't even know where to start. Can you please give me a date picker as an example? Thanks!

@Abdox3
Copy link
Author

Abdox3 commented Oct 4, 2018

@stefangabos
Copy link
Owner

I don't see anything different on the date picker itself. The rtl on the element the date picker is attached to is up to you to style. The format of that date is "a H:i d/m/Y"

@stefangabos
Copy link
Owner

And setting "icon_position" to "left"

@Abdox3
Copy link
Author

Abdox3 commented Oct 4, 2018

Thanks for fast responding 👍

The differences are: day's names start from right to left, this sequence: sa fr th we tu mo su, as well as the day's numbers start from right to left.
also the months goes as:
4 3 2 1
8 7 6 5
12 11 10 9.
Years sequence:
2013 2012 2011
2016 2015 2014
2019 2018 2017
The years and months, if you click the right arrow it goes to the previous year/month, the left arrows goes to the next year/month.

@stefangabos
Copy link
Owner

oh, i see now!
ok, i will implement that but i can't give you a deadline for it.
thanks for bringing this to my attention!

@Abdox3
Copy link
Author

Abdox3 commented Oct 4, 2018

Thanks I really appreciate that. And sure take your time.

@Abdox3 Abdox3 closed this as completed Oct 4, 2018
@stefangabos stefangabos reopened this Oct 4, 2018
@stefangabos
Copy link
Owner

stefangabos commented Oct 4, 2018

let's keep this open so I don't forget about it and also because you'll get notified when it's done. thanks!

@Abdox3
Copy link
Author

Abdox3 commented Oct 4, 2018

Ok, sorry I just thought that it would comment and close the tap x.x, it is just the first time I start an issue.
Thanks again.

@stefangabos
Copy link
Owner

you now have RTL support in the latest commit. would you be so kind to test it a little bit and let me know if it works as expected? thank you!

@Abdox3
Copy link
Author

Abdox3 commented Oct 27, 2018

Thank you very much, I have tested it, it works great!! <3

2018-10-27_115026

@stefangabos
Copy link
Owner

I am glad I could help - thank you for bringing this up and for testing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants