Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New section style #377

Closed
4 tasks done
stefan-niedermann opened this issue Apr 13, 2018 · 8 comments
Closed
4 tasks done

New section style #377

stefan-niedermann opened this issue Apr 13, 2018 · 8 comments
Labels
UX user experience
Milestone

Comments

@stefan-niedermann
Copy link
Member

stefan-niedermann commented Apr 13, 2018

  • align section titles with notes titles horizontally
  • remove background-color
  • add margin-top (or padding-top)
  • adjust text size so it matches excerpt text size

The result should look similar to the sections in the webinterface (compare e. g. to the activity feed)

grafik

Reason: They are currently catching too much attention.

@stefan-niedermann stefan-niedermann added the UX user experience label Apr 13, 2018
stefan-niedermann added a commit that referenced this issue Apr 13, 2018
@stefan-niedermann
Copy link
Member Author

stefan-niedermann commented Apr 13, 2018

cc @jancborchardt mmmh i think i might get used to it

device-2018-04-13-154950

stefan-niedermann added a commit that referenced this issue Apr 13, 2018
Adjusted text size and RTL support
stefan-niedermann added a commit that referenced this issue Apr 13, 2018
Use @Dimen variables for font sizes
stefan-niedermann added a commit that referenced this issue Apr 13, 2018
Use @Dimen variables for font sizes in drawer as well
stefan-niedermann added a commit that referenced this issue Apr 13, 2018
stefan-niedermann added a commit that referenced this issue Apr 13, 2018
Adjusted text size and RTL support
stefan-niedermann added a commit that referenced this issue Apr 13, 2018
Use @Dimen variables for font sizes
stefan-niedermann added a commit that referenced this issue Apr 13, 2018
Use @Dimen variables for font sizes in drawer as well
@stefan-niedermann stefan-niedermann added this to the 0.16.0 milestone Apr 13, 2018
@jancborchardt
Copy link
Member

Niiice! Looks great! :) Could even get some lighter font color, like 50% opacity.

@stefan-niedermann
Copy link
Member Author

sure, should excerpt and category get a lighter font as well?

@jancborchardt
Copy link
Member

@stefan-niedermann category can be lighter, but excerpt is good. :) The general rule is that meta-info (date & category) should be lighter than content (title & excerpt)

@korelstar
Copy link
Member

Please be aware, that these section titles are also used for sub-categories (when you have chosen a category from the navigation drawer) and not only for unimportant time information.

@jancborchardt
Copy link
Member

@korelstar what do you mean by sub-categories? In any case, categories are also secondary info (just like time), as said above.

@korelstar
Copy link
Member

@jancborchardt
The Notes (server) app maps directories to categories (and reverse). Hence, if you create a sub-directory Recipes/Cakes/ on the server (nobody can hinder you), you'll get a sub-category Cakes in the main-category Recipes (i.e., the category Recipes/Cakes). Currently, sub-categories are not propagated in the Android app, but you can use them if you have already hierarchically sorted notes on your server. E.g., if you select the category Recipes in the NavigationDrawer of the app, you'll get the following list:

  • Recipe 1
  • Recipe 2
  • section: Recipes / Cakes
  • Cake 1
  • Cake 2
  • section: Recipes / Lunch
  • Lunch 1
  • Lunch 2

@jancborchardt
Copy link
Member

Ok, that seems totally fine, and the grey/subdued style is apt for that.

Only one small thing: As the header should already show the main category name "Recipes", the sections can be just "Cakes" and "Lunch".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UX user experience
Projects
None yet
Development

No branches or pull requests

3 participants