Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slim loader not working properly with canJS 5, ES modules and multimain #1055

Open
pYr0x opened this issue Jul 28, 2018 · 5 comments
Open

slim loader not working properly with canJS 5, ES modules and multimain #1055

pYr0x opened this issue Jul 28, 2018 · 5 comments

Comments

@pYr0x
Copy link
Contributor

pYr0x commented Jul 28, 2018

i give the slim loader a try and want to use it in my multimain app,
we had an issue with multimain #823 and @m-mujica solved it.

but now i have a more complex app and it the slim-loader breaks.

the problem are shared dependencies.

i created an example app.

it would be nice if this problem will be solved. slim loader runs as twice as fast as steal.

@matthewp
Copy link
Member

Yeah, I'll see if I can fix this today.

@matthewp
Copy link
Member

There's a couple of bugs here at least:

  • Setting treeShaking: false in the BuildOptions does not turn off the client-side tree-shaking. @pYr0x as a stop-gap you can add "treeShaking": false in your package.json steal config and it will disable it in both places, and this will work.
  • The tree-shaking is removing a module, can/core I believe. Looking into why.

@matthewp
Copy link
Member

#1058 <- First bug.

@pYr0x
Copy link
Contributor Author

pYr0x commented Sep 26, 2018

@matthewp any idea when the second bug will be fixed?

@matthewp
Copy link
Member

I must have forgotten about this. I'll add it to my sprint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants