Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8 compatibility with Laravel 6.0 #35

Closed
adrenth opened this issue Jan 14, 2022 · 2 comments
Closed

PHP 8 compatibility with Laravel 6.0 #35

adrenth opened this issue Jan 14, 2022 · 2 comments

Comments

@adrenth
Copy link

adrenth commented Jan 14, 2022

Hi @staudenmeir,

Thank you for this wonderful addition to the Laravel framework. Currently we're using this package in October CMS (based on Laravel 6 LTS) and we would like to upgrade our project to PHP 8.0. Unfortunately version 1.2 of this package prevents us from upgrading. It would be great to have support for PHP 8.0 for the Laravel 6.0 version of this package.

Problem 1

  • Root composer.json requires staudenmeir/laravel-upsert 1.2 -> satisfiable by staudenmeir/laravel-upsert[v1.2].
  • staudenmeir/laravel-upsert v1.2 requires php ^7.2 -> your php version (8.0.14; overridden via config.platform, same as actual) does not satisfy that requirement.
@adrenth
Copy link
Author

adrenth commented Jan 14, 2022

Not sure how to submit a PR because the repository has no separate 1.2 branch, but I think adding this to composer.json would allow us to upgrade to PHP 8.

"php": "^7.2 || ^8.0",

@staudenmeir
Copy link
Owner

I released a new version for PHP 8.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants