Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move selected addresses for permissions to app db #18430

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Move selected addresses for permissions to app db #18430

merged 1 commit into from
Jan 10, 2024

Conversation

ajayesivan
Copy link
Contributor

@ajayesivan ajayesivan commented Jan 8, 2024 •
edited
Loading

fixes #18405

status: ready

@status-im-auto
Copy link
Member

status-im-auto commented Jan 8, 2024 •
edited
Loading

Jenkins Builds

Click to see older builds (20)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 8cec57e #1 2024-01-08 09:57:28 ~5 min ios 📱ipa 📲
✔️ 8cec57e #1 2024-01-08 09:58:57 ~7 min tests 📄log
✔️ 8cec57e #1 2024-01-08 09:59:04 ~7 min android-e2e 🤖apk 📲
✔️ 8cec57e #1 2024-01-08 09:59:12 ~7 min android 🤖apk 📲
❌ 09498c5 #3 2024-01-08 10:13:08 ~3 min tests 📄log
✔️ 09498c5 #3 2024-01-08 10:15:17 ~5 min ios 📱ipa 📲
✔️ 09498c5 #3 2024-01-08 10:16:23 ~6 min android-e2e 🤖apk 📲
✔️ 09498c5 #3 2024-01-08 10:17:09 ~7 min android 🤖apk 📲
✔️ 6669baa #4 2024-01-09 08:22:06 ~5 min ios 📱ipa 📲
✔️ 6669baa #4 2024-01-09 08:22:56 ~6 min tests 📄log
✔️ 6669baa #4 2024-01-09 08:24:54 ~8 min android-e2e 🤖apk 📲
✔️ 6669baa #4 2024-01-09 08:25:00 ~8 min android 🤖apk 📲
✔️ d7f77a5 #5 2024-01-09 12:04:54 ~5 min ios 📱ipa 📲
✔️ d7f77a5 #5 2024-01-09 12:06:16 ~6 min tests 📄log
✔️ d7f77a5 #5 2024-01-09 12:08:15 ~8 min android-e2e 🤖apk 📲
✔️ d7f77a5 #5 2024-01-09 12:08:19 ~8 min android 🤖apk 📲
✔️ 3c1b88f #6 2024-01-09 12:35:04 ~5 min ios 📱ipa 📲
✔️ 3c1b88f #6 2024-01-09 12:35:59 ~6 min tests 📄log
✔️ 3c1b88f #6 2024-01-09 12:38:19 ~8 min android-e2e 🤖apk 📲
✔️ 3c1b88f #6 2024-01-09 12:38:22 ~8 min android 🤖apk 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 6dc2d71 #8 2024-01-09 16:15:31 ~5 min ios 📱ipa 📲
✔️ 6dc2d71 #8 2024-01-09 16:15:46 ~5 min tests 📄log
✔️ 6dc2d71 #8 2024-01-09 16:25:34 ~15 min android-e2e 🤖apk 📲
✔️ 6dc2d71 #8 2024-01-09 16:25:41 ~15 min android 🤖apk 📲
✔️ 62707b9 #9 2024-01-10 03:38:41 ~5 min ios 📱ipa 📲
✔️ 62707b9 #9 2024-01-10 03:38:42 ~5 min tests 📄log
✔️ 62707b9 #9 2024-01-10 03:40:56 ~8 min android-e2e 🤖apk 📲
✔️ 62707b9 #9 2024-01-10 03:41:33 ~8 min android 🤖apk 📲

@ajayesivan ajayesivan force-pushed the 18405-move-selected-addresses-state-to-app-db branch 2 times, most recently from d232d0e to 09498c5 Compare January 8, 2024 10:09
@ajayesivan ajayesivan requested a review from ilmotta January 8, 2024 10:10
@ajayesivan ajayesivan self-assigned this Jan 8, 2024
@ajayesivan ajayesivan force-pushed the 18405-move-selected-addresses-state-to-app-db branch from 09498c5 to 6669baa Compare January 9, 2024 08:16
@ajayesivan ajayesivan changed the title [WIP] Move selected addresses for permissions to app db Move selected addresses for permissions to app db Jan 9, 2024
@ajayesivan ajayesivan marked this pull request as ready for review January 9, 2024 11:59
ajayesivan
ajayesivan commented Jan 9, 2024
View reviewed changes
src/status_im/contexts/communities/events.cljs
Comment on lines +193 to +194
:communities/previous-permission-addresses addresses
:communities/selected-permission-addresses addresses)}))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:communities/selected-permission-addresses - This key will track the selected address for both passing it to the status-go API and displaying it in the UI.

:communities/previous-permission-addresses - This key is specifically for storing the previously selected state. It enables us to reset to the previous address when the user clicks 'Cancel' after making an edit.

@ilmotta, I hope these new key names make more sense.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's perfect @ajayesivan. You even managed to come up with names with the same length, god mode.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a pain 😓 I renamed it 4 or 5 times and finally ended up with this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajayesivan ajayesivan force-pushed the 18405-move-selected-addresses-state-to-app-db branch from d7f77a5 to 3c1b88f Compare January 9, 2024 12:29
ilmotta
ilmotta approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@ilmotta ilmotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

src/status_im/contexts/communities/events.cljs
Comment on lines +193 to +194
:communities/previous-permission-addresses addresses
:communities/selected-permission-addresses addresses)}))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's perfect @ajayesivan. You even managed to come up with names with the same length, god mode.

src/status_im/subs/root.cljs Outdated
@@ -145,7 +145,8 @@
(reg-root-key-sub :communities/collapsed-categories :communities/collapsed-categories)
(reg-root-key-sub :communities/selected-tab :communities/selected-tab)
(reg-root-key-sub :contract-communities :contract-communities)
(reg-root-key-sub :communities/addresses-for-permissions :communities/addresses-for-permissions)
(reg-root-key-sub :communities/selected-permission-addresses
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The args fit on the same line.

@ajayesivan ajayesivan force-pushed the 18405-move-selected-addresses-state-to-app-db branch from 3c1b88f to bd81420 Compare January 9, 2024 16:07
@ajayesivan ajayesivan force-pushed the 18405-move-selected-addresses-state-to-app-db branch from bd81420 to 6dc2d71 Compare January 9, 2024 16:09
@status-im-auto
Copy link
Member

4% of end-end tests have passed

Total executed tests: 48
Failed tests: 45
Expected to fail tests: 1
Passed tests: 2

IDs of failed tests: 702809,702782,702733,702784,703194,702859,702777,702732,702813,703133,702957,702851,702840,703495,703086,702948,702894,702745,702783,702850,702742,703297,704615,702869,703496,702936,702855,703202,703391,702786,702839,702947,702838,702844,702846,702843,702807,702731,702808,702730,702845,702958,703629,703382,702841 

IDs of expected to fail tests: 703503

Failed tests (45)

Click to expand
  • Rerun failed tests

    • Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 
    Test setup failed: critical/chats/test_group_chat.py:19: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(3)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    2. test_group_chat_mute_chat, id: 703495 

    Test setup failed: critical/chats/test_group_chat.py:19: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(3)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    3. test_group_chat_send_image_save_and_share, id: 703297 

    Test setup failed: critical/chats/test_group_chat.py:19: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(3)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    4. test_group_chat_reactions, id: 703202 

    Test setup failed: critical/chats/test_group_chat.py:19: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(3)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    5. test_group_chat_join_send_text_messages_push, id: 702807 

    Test setup failed: critical/chats/test_group_chat.py:19: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(3)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    6. test_group_chat_offline_pn, id: 702808 

    Test setup failed: critical/chats/test_group_chat.py:19: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(3)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'

    [[Data delivery issue]]

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809 

    Test setup failed: critical/chats/test_public_chat_browsing.py:802: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    2. test_community_hashtag_links_to_community_channels, id: 702948 

    Test setup failed: critical/chats/test_public_chat_browsing.py:802: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    3. test_community_mentions_push_notification, id: 702786 

    Test setup failed: critical/chats/test_public_chat_browsing.py:802: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    4. test_community_leave, id: 702845 

    Test setup failed: critical/chats/test_public_chat_browsing.py:802: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    5. test_community_join_when_node_owner_offline, id: 703629 

    Test setup failed: critical/chats/test_public_chat_browsing.py:802: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'

    [[Can't join a community if admin goes offline, https://github.com//issues/17678]]

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782 

    Test setup failed: critical/chats/test_1_1_public_chats.py:19: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733 

    Test setup failed: critical/chats/test_1_1_public_chats.py:19: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    3. test_1_1_chat_push_emoji, id: 702813 

    Test setup failed: critical/chats/test_1_1_public_chats.py:19: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745 

    Test setup failed: critical/chats/test_1_1_public_chats.py:19: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    5. test_1_1_chat_edit_message, id: 702855 

    Test setup failed: critical/chats/test_1_1_public_chats.py:19: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    6. test_1_1_chat_send_image_save_and_share, id: 703391 

    Test setup failed: critical/chats/test_1_1_public_chats.py:19: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    7. test_1_1_chat_pin_messages, id: 702731 

    Test setup failed: critical/chats/test_1_1_public_chats.py:19: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    8. test_1_1_chat_message_reaction, id: 702730 

    Test setup failed: critical/chats/test_1_1_public_chats.py:19: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936 

    Test setup failed: activity_center/test_activity_center.py:233: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947 

    Test setup failed: activity_center/test_activity_center.py:233: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777 

    Test setup failed: activity_center/test_activity_center.py:18: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851 

    Test setup failed: activity_center/test_activity_center.py:18: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    3. test_activity_center_contact_request_decline, id: 702850 

    Test setup failed: activity_center/test_activity_center.py:18: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133 

    Test setup failed: critical/chats/test_public_chat_browsing.py:22: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(1)
base_test_case.py:309: in create_shared_drivers
    drivers = loop.run_until_complete(start_threads(test_suite_data.current_test.name,
/usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
    return future.result()
__init__.py:26: in start_threads
    returns[k] = await returns[k]
/usr/lib/python3.10/concurrent/futures/thread.py:58: in run
    result = self.fn(*self.args, **self.kwargs)
/home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/webdriver.py:257: in __init__
    super().__init__(
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:206: in __init__
    self.start_session(capabilities)
/home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/webdriver.py:346: in start_session
    response = self.execute(RemoteCommand.NEW_SESSION, w3c_caps)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:345: in execute
    self.error_handler.check_response(response)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/errorhandler.py:229: in check_response
    raise exception_class(message, screen, stacktrace)
 Unexpected server error.



    2. test_community_copy_and_paste_message_in_chat_input, id: 702742 

    Test setup failed: critical/chats/test_public_chat_browsing.py:22: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(1)
base_test_case.py:309: in create_shared_drivers
    drivers = loop.run_until_complete(start_threads(test_suite_data.current_test.name,
/usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
    return future.result()
__init__.py:26: in start_threads
    returns[k] = await returns[k]
/usr/lib/python3.10/concurrent/futures/thread.py:58: in run
    result = self.fn(*self.args, **self.kwargs)
/home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/webdriver.py:257: in __init__
    super().__init__(
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:206: in __init__
    self.start_session(capabilities)
/home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/webdriver.py:346: in start_session
    response = self.execute(RemoteCommand.NEW_SESSION, w3c_caps)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:345: in execute
    self.error_handler.check_response(response)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/errorhandler.py:229: in check_response
    raise exception_class(message, screen, stacktrace)
 Unexpected server error.



    3. test_community_undo_delete_message, id: 702869 

    Test setup failed: critical/chats/test_public_chat_browsing.py:22: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(1)
base_test_case.py:309: in create_shared_drivers
    drivers = loop.run_until_complete(start_threads(test_suite_data.current_test.name,
/usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
    return future.result()
__init__.py:26: in start_threads
    returns[k] = await returns[k]
/usr/lib/python3.10/concurrent/futures/thread.py:58: in run
    result = self.fn(*self.args, **self.kwargs)
/home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/webdriver.py:257: in __init__
    super().__init__(
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:206: in __init__
    self.start_session(capabilities)
/home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/webdriver.py:346: in start_session
    response = self.execute(RemoteCommand.NEW_SESSION, w3c_caps)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:345: in execute
    self.error_handler.check_response(response)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/errorhandler.py:229: in check_response
    raise exception_class(message, screen, stacktrace)
 Unexpected server error.



    4. test_community_navigate_to_channel_when_relaunch, id: 702846 

    Test setup failed: critical/chats/test_public_chat_browsing.py:22: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(1)
base_test_case.py:309: in create_shared_drivers
    drivers = loop.run_until_complete(start_threads(test_suite_data.current_test.name,
/usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
    return future.result()
__init__.py:26: in start_threads
    returns[k] = await returns[k]
/usr/lib/python3.10/concurrent/futures/thread.py:58: in run
    result = self.fn(*self.args, **self.kwargs)
/home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/webdriver.py:257: in __init__
    super().__init__(
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:206: in __init__
    self.start_session(capabilities)
/home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/webdriver.py:346: in start_session
    response = self.execute(RemoteCommand.NEW_SESSION, w3c_caps)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:345: in execute
    self.error_handler.check_response(response)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/errorhandler.py:229: in check_response
    raise exception_class(message, screen, stacktrace)
 Unexpected server error.



    5. test_community_mute_community_and_channel, id: 703382 

    Test setup failed: critical/chats/test_public_chat_browsing.py:22: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(1)
base_test_case.py:309: in create_shared_drivers
    drivers = loop.run_until_complete(start_threads(test_suite_data.current_test.name,
/usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
    return future.result()
__init__.py:26: in start_threads
    returns[k] = await returns[k]
/usr/lib/python3.10/concurrent/futures/thread.py:58: in run
    result = self.fn(*self.args, **self.kwargs)
/home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/webdriver.py:257: in __init__
    super().__init__(
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:206: in __init__
    self.start_session(capabilities)
/home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/webdriver.py:346: in start_session
    response = self.execute(RemoteCommand.NEW_SESSION, w3c_caps)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:345: in execute
    self.error_handler.check_response(response)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/errorhandler.py:229: in check_response
    raise exception_class(message, screen, stacktrace)
 Unexpected server error.



    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957 

    Test setup failed: activity_center/test_activity_center.py:380: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    2. test_activity_center_admin_notification_accept_swipe, id: 702958 

    Test setup failed: activity_center/test_activity_center.py:380: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194 

    Test setup failed: critical/chats/test_public_chat_browsing.py:281: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    2. test_community_one_image_send_reply, id: 702859 

    Test setup failed: critical/chats/test_public_chat_browsing.py:281: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    3. test_community_emoji_send_copy_paste_reply, id: 702840 

    Test setup failed: critical/chats/test_public_chat_browsing.py:281: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    4. test_community_mark_all_messages_as_read, id: 703086 

    Test setup failed: critical/chats/test_public_chat_browsing.py:281: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    5. test_community_contact_block_unblock_offline, id: 702894 

    Test setup failed: critical/chats/test_public_chat_browsing.py:281: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'

    [[Message can be missed after unblock: https://github.com//issues/16873]]

    6. test_community_edit_delete_message_when_offline, id: 704615 

    Test setup failed: critical/chats/test_public_chat_browsing.py:281: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    7. test_community_message_delete, id: 702839 

    Test setup failed: critical/chats/test_public_chat_browsing.py:281: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    8. test_community_message_send_check_timestamps_sender_username, id: 702838 

    Test setup failed: critical/chats/test_public_chat_browsing.py:281: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    Device sessions

    9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844 

    Test setup failed: critical/chats/test_public_chat_browsing.py:281: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    10. test_community_message_edit, id: 702843 

    Test setup failed: critical/chats/test_public_chat_browsing.py:281: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    11. test_community_unread_messages_badge, id: 702841 

    Test setup failed: critical/chats/test_public_chat_browsing.py:281: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784 

    Test setup failed: critical/chats/test_1_1_public_chats.py:523: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783 

    Test setup failed: critical/chats/test_1_1_public_chats.py:523: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'

    [[Data delivery issue]]

    3. test_1_1_chat_mute_chat, id: 703496 

    Test setup failed: critical/chats/test_1_1_public_chats.py:523: in prepare_devices
    self.drivers, self.loop = create_shared_drivers(2)
base_test_case.py:323: in create_shared_drivers
    raise e
base_test_case.py:316: in create_shared_drivers
    test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
 '_asyncio.Future' object has no attribute 'session_id'



    Expected to fail tests (1)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Passed tests (2)

    Click to expand

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    @status-im-auto
    Copy link
    Member

    79% of end-end tests have passed

    Total executed tests: 48
Failed tests: 8
Expected to fail tests: 2
Passed tests: 38

    IDs of failed tests: 702809,702957,702948,702786,702838,702845,702958,703629 

    IDs of expected to fail tests: 703503,702808

    Failed tests (8)

    Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_send_check_timestamps_sender_username, id: 702838

    Device 2: Find `Username` by `xpath`: `//*[starts-with(@text,'new message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/android.view.ViewGroup/android.widget.TextView[1]`
    Device 2: `Username` is `user_1` 

    critical/chats/test_public_chat_browsing.py:339: in test_community_message_send_check_timestamps_sender_username
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Timestamp is not shown, expected: '7:30 PM, 7:29 PM, 7:28 PM, 7:27 PM', in fact: '7:26 PM'



    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809 

    Test setup failed: critical/chats/test_public_chat_browsing.py:835: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:435: in join_community
    self.join_button.wait_and_click(120)
../views/base_element.py:96: in wait_and_click
    self.wait_for_visibility_of_element(sec)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element



    2. test_community_hashtag_links_to_community_channels, id: 702948 

    Test setup failed: critical/chats/test_public_chat_browsing.py:835: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:435: in join_community
    self.join_button.wait_and_click(120)
../views/base_element.py:96: in wait_and_click
    self.wait_for_visibility_of_element(sec)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element



    3. test_community_mentions_push_notification, id: 702786

    Device 2: Find Text by xpath: //android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/')]
    Device 2: Wait for element Button for max 120s and click when it is available 

    Test setup failed: critical/chats/test_public_chat_browsing.py:835: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:435: in join_community
    self.join_button.wait_and_click(120)
../views/base_element.py:96: in wait_and_click
    self.wait_for_visibility_of_element(sec)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    4. test_community_leave, id: 702845 

    Test setup failed: critical/chats/test_public_chat_browsing.py:835: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:435: in join_community
    self.join_button.wait_and_click(120)
../views/base_element.py:96: in wait_and_click
    self.wait_for_visibility_of_element(sec)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element



    5. test_community_join_when_node_owner_offline, id: 703629 

    Test setup failed: critical/chats/test_public_chat_browsing.py:835: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:435: in join_community
    self.join_button.wait_and_click(120)
../views/base_element.py:96: in wait_and_click
    self.wait_for_visibility_of_element(sec)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element

    [[Can't join a community if admin goes offline, https://github.com//issues/17678]]

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957

    Device 2: Find Text by xpath: //android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/')]
    Device 2: Wait for element Button for max 120s and click when it is available 

    Test setup failed: activity_center/test_activity_center.py:409: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:435: in join_community
    self.join_button.wait_and_click(120)
../views/base_element.py:96: in wait_and_click
    self.wait_for_visibility_of_element(sec)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958 

    Test setup failed: activity_center/test_activity_center.py:409: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:435: in join_community
    self.join_button.wait_and_click(120)
../views/base_element.py:96: in wait_and_click
    self.wait_for_visibility_of_element(sec)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Button by accessibility id:`show-request-to-join-screen-button` is not found on the screen after wait_for_visibility_of_element



    Expected to fail tests (2)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_offline_pn, id: 702808

    Device 3: Looking for a message by text: message from old member
    Device 3: Looking for a message by text: message from new member 

    critical/chats/test_group_chat.py:324: in test_group_chat_offline_pn
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Messages PN was not fetched from offline

    [[Data delivery issue]]

    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Passed tests (38)

    Click to expand

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    9. test_community_message_edit, id: 702843
    Device sessions

    10. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_mute_chat, id: 703495
    Device sessions

    3. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    4. test_group_chat_reactions, id: 703202
    Device sessions

    5. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    @ajayesivan ajayesivan force-pushed the 18405-move-selected-addresses-state-to-app-db branch from 6dc2d71 to 62707b9 Compare January 10, 2024 03:32
    @ajayesivan ajayesivan merged commit 1eb9e87 into develop Jan 10, 2024
    6 checks passed
    @ajayesivan ajayesivan deleted the 18405-move-selected-addresses-state-to-app-db branch January 10, 2024 03:45
    briansztamfater pushed a commit that referenced this pull request Jan 11, 2024
    @ajayesivan @briansztamfater
    Move selected addresses for permissions to app db (#18430)
    5af5e57
    @ajayesivan ajayesivan mentioned this pull request Feb 9, 2024
    Merged
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @ilmotta ilmotta ilmotta approved these changes

    @yqrashawn yqrashawn yqrashawn approved these changes

    @FFFra FFFra Awaiting requested review from FFFra

    @J-Son89 J-Son89 Awaiting requested review from J-Son89

    Assignees

    @ajayesivan ajayesivan

    Labels
    skip-manual-qa
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Addresses for permissions screen: Move selected addresses state to app-db
    4 participants
    @ajayesivan @status-im-auto @ilmotta @yqrashawn