Add lastOpenedAt key to communities #18333
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibrkhalil
changed the title
Jenkins Builds
|
79% of end-end tests have passedFailed tests (5)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (5)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Passed tests (38)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
|
Parveshdhull
reviewed
Jan 1, 2024
| [id] | ||
| (let [id (or id (rf/sub [:get-screen-params :community-overview])) | ||
| customization-color (rf/sub [:profile/customization-color])] | ||
| (rn/use-effect #(rf/dispatch [:communities/update-last-opened-at id]) [id]) |
There was a problem hiding this comment.
Hi @ibrkhalil, Thank you very much for your PR.
Maybe we can create another event, something like :communities/navigate-to-community (similar to :chat/navigate-to-chat) and handle this update there. wdyt?
There was a problem hiding this comment.
I think the only benefit for that would be better naming, Will do.
Parveshdhull
reviewed
Jan 1, 2024
| @@ -169,6 +170,13 @@ | |||
| {} | |||
| categories))})) | |||
|
|
|||
| (rf/reg-event-fx :communities/update-last-opened-at | |||
| (fn [_ [community-id]] | |||
| {:json-rpc/call [{:method "wakuext_updateLastOpenedAt" | |||
There was a problem hiding this comment.
Also, probably we should rename this end point. It somewhat gives idea that we are providing time at which community is opened.
There was a problem hiding this comment.
As Samuel mentioned in original issue, maybe something like CommunityOpened
There was a problem hiding this comment.
What do you think about wakuext_communityUpdateLastOpenedAt
ibrkhalil
changed the title
|
Hey @ibrkhalil! What is the status of this PR? I see that it is not approved and remains in E2E column for couple of weeks already. Once you get PR approval, please rebase it (both mobile and status go branches) and add one of the labels (request manual qa or skip manual qa). In case manual qa is not required - we still need to rerun e2e tests after rebase. In case manual qa is required - please add testing notes in the PR description. Thank you. |
|
Closed in favor of: #18439 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for #17337
Adds the last opened at key to communities to know when was a community last opened (This is done currently for overview pages, Internal links not tested yet.)
status: ready