fixed dark border around the community logo #18314

jo-mut · 2023-12-28T11:53:41Z

This PR removes the dark border around the community logo on communities page. The bug is only reproducible when the user has not yet joined the community

fixes #17565

Before & After screen shots

status-im-auto · 2023-12-28T11:58:22Z

Jenkins Builds

Click to see older builds (26)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`7adc4e3`	#1	2023-12-28 11:58:21	~4 min	`tests`	📄`log`
✔️	`7adc4e3`	#1	2023-12-28 12:00:53	~6 min	`android`	🤖`apk` 📲
✔️	`7adc4e3`	#1	2023-12-28 12:01:09	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`7adc4e3`	#1	2023-12-28 12:02:38	~8 min	`ios`	📱`ipa` 📲

✔️	`83c4990`	#2	2023-12-28 20:21:38	~4 min	`tests`	📄`log`
✔️	`83c4990`	#2	2023-12-28 20:23:34	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`83c4990`	#2	2023-12-28 20:24:51	~8 min	`android`	🤖`apk` 📲

✔️	`9d3303d`	#3	2023-12-29 14:01:39	~4 min	`tests`	📄`log`
✔️	`9d3303d`	#3	2023-12-29 14:03:42	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`9d3303d`	#3	2023-12-29 14:04:58	~7 min	`android`	🤖`apk` 📲
✔️	`9d3303d`	#3	2023-12-29 14:09:28	~12 min	`ios`	📱`ipa` 📲

✔️	`a5b088c`	#4	2024-01-01 23:58:57	~4 min	`tests`	📄`log`
✔️	`a5b088c`	#4	2024-01-02 00:00:56	~6 min	`ios`	📱`ipa` 📲
✔️	`a5b088c`	#4	2024-01-02 00:02:19	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`a5b088c`	#4	2024-01-02 00:02:20	~7 min	`android`	🤖`apk` 📲

✔️	`63f9156`	#5	2024-01-02 15:13:08	~4 min	`tests`	📄`log`
✔️	`63f9156`	#5	2024-01-02 15:15:20	~6 min	`ios`	📱`ipa` 📲
✔️	`63f9156`	#5	2024-01-02 15:15:27	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`63f9156`	#5	2024-01-02 15:15:50	~6 min	`android`	🤖`apk` 📲

✔️	`5b12fe2`	#6	2024-01-08 16:34:16	~5 min	`ios`	📱`ipa` 📲
✔️	`5b12fe2`	#6	2024-01-08 16:35:01	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`5b12fe2`	#6	2024-01-08 16:35:14	~6 min	`android`	🤖`apk` 📲

✔️	`51f5f14`	#7	2024-01-08 21:34:45	~5 min	`tests`	📄`log`
✔️	`51f5f14`	#7	2024-01-08 21:35:18	~5 min	`ios`	📱`ipa` 📲
✔️	`51f5f14`	#7	2024-01-08 21:36:07	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`51f5f14`	#7	2024-01-08 21:36:33	~7 min	`android`	🤖`apk` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`2e9c95e`	#8	2024-01-12 10:31:55	~5 min	`tests`	📄`log`
✔️	`2e9c95e`	#8	2024-01-12 10:33:01	~7 min	`ios`	📱`ipa` 📲
✔️	`2e9c95e`	#8	2024-01-12 10:33:19	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`2e9c95e`	#8	2024-01-12 10:34:34	~8 min	`android`	🤖`apk` 📲

✔️	`965aadb`	#9	2024-01-12 17:28:35	~5 min	`tests`	📄`log`
✔️	`965aadb`	#9	2024-01-12 17:29:44	~6 min	`ios`	📱`ipa` 📲
✔️	`965aadb`	#9	2024-01-12 17:30:52	~7 min	`android`	🤖`apk` 📲
✔️	`965aadb`	#9	2024-01-12 17:30:53	~7 min	`android-e2e`	🤖`apk` 📲

status-im-auto · 2023-12-28T12:33:41Z

50% of end-end tests have passed

Total executed tests: 48
Failed tests: 20
Expected to fail tests: 4
Passed tests: 24

IDs of failed tests: 702809,703194,702859,702957,702840,703086,702948,702894,704615,702936,702786,702839,702947,702838,702844,702843,702845,702958,703629,702841

IDs of expected to fail tests: 702732,703503,702731,702808

Failed tests (20)

Click to expand

Rerun failed tests

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply, id: 703194
Test setup failed: critical/chats/test_public_chat_browsing.py:319: in prepare_devices self.community_2.join_community() ../views/chat_view.py:428: in join_community self.join_button.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `show-request-to-join-screen-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
2. test_community_one_image_send_reply, id: 702859
Test setup failed: critical/chats/test_public_chat_browsing.py:319: in prepare_devices self.community_2.join_community() ../views/chat_view.py:428: in join_community self.join_button.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `show-request-to-join-screen-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
3. test_community_emoji_send_copy_paste_reply, id: 702840
Test setup failed: critical/chats/test_public_chat_browsing.py:319: in prepare_devices self.community_2.join_community() ../views/chat_view.py:428: in join_community self.join_button.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `show-request-to-join-screen-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
4. test_community_mark_all_messages_as_read, id: 703086
Test setup failed: critical/chats/test_public_chat_browsing.py:319: in prepare_devices self.community_2.join_community() ../views/chat_view.py:428: in join_community self.join_button.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `show-request-to-join-screen-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
5. test_community_contact_block_unblock_offline, id: 702894
Test setup failed: critical/chats/test_public_chat_browsing.py:319: in prepare_devices self.community_2.join_community() ../views/chat_view.py:428: in join_community self.join_button.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `show-request-to-join-screen-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception [[Message can be missed after unblock: https://github.com//issues/16873]]
6. test_community_edit_delete_message_when_offline, id: 704615
Test setup failed: critical/chats/test_public_chat_browsing.py:319: in prepare_devices self.community_2.join_community() ../views/chat_view.py:428: in join_community self.join_button.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `show-request-to-join-screen-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
7. test_community_message_delete, id: 702839
Test setup failed: critical/chats/test_public_chat_browsing.py:319: in prepare_devices self.community_2.join_community() ../views/chat_view.py:428: in join_community self.join_button.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `show-request-to-join-screen-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
8. test_community_message_send_check_timestamps_sender_username, id: 702838
Device 2: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/')]` Device 2: Find `Button` by `accessibility id`: `show-request-to-join-screen-button` Test setup failed: critical/chats/test_public_chat_browsing.py:319: in prepare_devices self.community_2.join_community() ../views/chat_view.py:428: in join_community self.join_button.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `show-request-to-join-screen-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Test setup failed: critical/chats/test_public_chat_browsing.py:319: in prepare_devices self.community_2.join_community() ../views/chat_view.py:428: in join_community self.join_button.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `show-request-to-join-screen-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
10. test_community_message_edit, id: 702843
Test setup failed: critical/chats/test_public_chat_browsing.py:319: in prepare_devices self.community_2.join_community() ../views/chat_view.py:428: in join_community self.join_button.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `show-request-to-join-screen-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
11. test_community_unread_messages_badge, id: 702841
Test setup failed: critical/chats/test_public_chat_browsing.py:319: in prepare_devices self.community_2.join_community() ../views/chat_view.py:428: in join_community self.join_button.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `show-request-to-join-screen-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_mentions, id: 702957
Device 2: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/')]` Device 2: Find `Button` by `accessibility id`: `show-request-to-join-screen-button` Test setup failed: activity_center/test_activity_center.py:409: in prepare_devices self.community_2.join_community() ../views/chat_view.py:428: in join_community self.join_button.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `show-request-to-join-screen-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_activity_center_admin_notification_accept_swipe, id: 702958
Test setup failed: activity_center/test_activity_center.py:409: in prepare_devices self.community_2.join_community() ../views/chat_view.py:428: in join_community self.join_button.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `show-request-to-join-screen-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Class TestActivityMultipleDevicePR:

1. test_navigation_jump_to, id: 702936
Device 2: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/')]` Device 2: Find `Button` by `accessibility id`: `show-request-to-join-screen-button` Test setup failed: activity_center/test_activity_center.py:270: in prepare_devices self.community_2.join_community() ../views/chat_view.py:428: in join_community self.join_button.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `show-request-to-join-screen-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Test setup failed: activity_center/test_activity_center.py:270: in prepare_devices self.community_2.join_community() ../views/chat_view.py:428: in join_community self.join_button.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `show-request-to-join-screen-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_markdown_support, id: 702809
Test setup failed: critical/chats/test_public_chat_browsing.py:835: in prepare_devices self.community_2.join_community() ../views/chat_view.py:428: in join_community self.join_button.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `show-request-to-join-screen-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
2. test_community_hashtag_links_to_community_channels, id: 702948
Test setup failed: critical/chats/test_public_chat_browsing.py:835: in prepare_devices self.community_2.join_community() ../views/chat_view.py:428: in join_community self.join_button.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `show-request-to-join-screen-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception [[Can't navigate to a channel by hashtag link, https://github.com//issues/18095]]
3. test_community_mentions_push_notification, id: 702786
Device 2: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/')]` Device 2: Find `Button` by `accessibility id`: `show-request-to-join-screen-button` Test setup failed: critical/chats/test_public_chat_browsing.py:835: in prepare_devices self.community_2.join_community() ../views/chat_view.py:428: in join_community self.join_button.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `show-request-to-join-screen-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
4. test_community_leave, id: 702845
Test setup failed: critical/chats/test_public_chat_browsing.py:835: in prepare_devices self.community_2.join_community() ../views/chat_view.py:428: in join_community self.join_button.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `show-request-to-join-screen-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
5. test_community_join_when_node_owner_offline, id: 703629
Test setup failed: critical/chats/test_public_chat_browsing.py:835: in prepare_devices self.community_2.join_community() ../views/chat_view.py:428: in join_community self.join_button.click() ../views/base_element.py:90: in click self.find_element().click() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `show-request-to-join-screen-button` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Expected to fail tests (4)

Click to expand

Class TestCommunityOneDeviceMerged:

1. test_community_discovery, id: 703503
`Test is not run, e2e blocker` [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_pin_messages, id: 702731
`Test is not run, e2e blocker` [[reason: [NOTRUN] Pin feature is in development]]

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
`Test is not run, e2e blocker` [[reason: [NOTRUN] Pin feature is in development]]
2. test_group_chat_offline_pn, id: 702808
Device 3: Looking for a message by text: message from old member Device 3: Looking for a message by text: message from new member `critical/chats/test_group_chat.py:324: in test_group_chat_offline_pn self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Messages PN was not fetched from offline` [[Data delivery issue]] Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot

Passed tests (24)

Click to expand

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs
2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
3. test_community_undo_delete_message, id: 702869
Device sessions Device 1: Steps, video, logs
4. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
5. test_community_mute_community_and_channel, id: 703382
Device sessions Device 1: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_mute_chat, id: 703496
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_send_image_save_and_share, id: 703391
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_mute_chat, id: 703495
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_send_image_save_and_share, id: 703297
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_reactions, id: 703202
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
4. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_add_contact_field_validation, id: 702777
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestDeepLinksOneDevice:

1. test_links_open_universal_links_from_chat, id: 704613
Device sessions Device 1: Steps, video, logs
2. test_links_deep_links, id: 702775
Device sessions Device 1: Steps, video, logs

src/status_im/common/scroll_page/style.cljs

status-im-auto · 2023-12-28T17:11:39Z

88% of end-end tests have passed

Total executed tests: 48
Failed tests: 1
Expected to fail tests: 5
Passed tests: 42

IDs of failed tests: 702786

IDs of expected to fail tests: 702731,702808,702948,702732,703503

Failed tests (1)

Click to expand

Rerun failed tests

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_mentions_push_notification, id: 702786

# STEP: Invited member gets push notification with the mention and tap it
Device 2: Getting PN by 'user_2'

critical/chats/test_public_chat_browsing.py:925: in test_community_mentions_push_notification
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message reaction is not shown for the sender
E    Push notification with the mention was not received by the invited member

Device sessions

Device 1:

Device 2:

Expected to fail tests (5)

Click to expand

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_hashtag_links_to_community_channels, id: 702948

Device 2: Click until ChatMessageInput by accessibility id: chat-message-input will be presented
Device 2: Looking for a message by text: #cats

critical/chats/test_public_chat_browsing.py:1042: in test_community_hashtag_links_to_community_channels
    self.channel_2.chat_element_by_text(message_with_hashtag).click_on_link_inside_message_body()
../views/chat_view.py:193: in click_on_link_inside_message_body
    self.message_body.wait_for_visibility_of_element(30)
../views/base_element.py:139: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by xpath:`//android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'#cats')]` is not found on the screen after wait_for_visibility_of_element

[[Can't navigate to a channel by hashtag link, https://github.com//issues/18095]]

Device sessions

Device 1:

Device 2:

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_offline_pn, id: 702808
Device 3: Looking for a message by text: message from old member Device 3: Looking for a message by text: message from new member `critical/chats/test_group_chat.py:324: in test_group_chat_offline_pn self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Messages PN was not fetched from offline` [[Data delivery issue]] Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot
2. test_group_chat_pin_messages, id: 702732
`Test is not run, e2e blocker` [[reason: [NOTRUN] Pin feature is in development]]

Class TestCommunityOneDeviceMerged:

1. test_community_discovery, id: 703503
`Test is not run, e2e blocker` [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_pin_messages, id: 702731
`Test is not run, e2e blocker` [[reason: [NOTRUN] Pin feature is in development]]

Passed tests (42)

Click to expand

Class TestDeepLinksOneDevice:

1. test_links_deep_links, id: 702775
Device sessions Device 1: Steps, video, logs
2. test_links_open_universal_links_from_chat, id: 704613
Device sessions Device 1: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_reactions, id: 703202
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_send_image_save_and_share, id: 703297
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
4. test_group_chat_mute_chat, id: 703495
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_markdown_support, id: 702809
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_join_when_node_owner_offline, id: 703629
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_mute_chat, id: 703496
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
2. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
3. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs
4. test_community_undo_delete_message, id: 702869
Device sessions Device 1: Steps, video, logs
5. test_community_mute_community_and_channel, id: 703382
Device sessions Device 1: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_add_contact_field_validation, id: 702777
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_contact_block_unblock_offline, id: 702894
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_message_send_check_timestamps_sender_username, id: 702838
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_edit_delete_message_when_offline, id: 704615
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
11. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_send_image_save_and_share, id: 703391
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

jo-mut · 2024-01-04T12:11:51Z

@Francesca-G I worked on this and looks now. You could take a look and maybe confirm

Francesca-G · 2024-01-05T10:12:15Z

@Francesca-G I worked on this and looks now. You could take a look and maybe confirm

looks good to me as well ✨

mariia-skrypnyk · 2024-01-12T16:52:08Z

Hi @jo-mut! Thanks fro your PR!
I've tested it both on iOS and Android and can agree that no dark border around the community logo anymore!
So you can merge it!

Can I ask you for a small comment like "design review is required" for your future PR's in case it is needed.
If you'll do so, for us -QA's it is a flag to move your PR to the Design review column after testing. As it's better not to involve designers to comment PR's that are not tested yet. Hope it make sense! Thanks!

jo-mut · 2024-01-12T17:10:43Z

@mariia-skrypnyk I may have just missed a step and involved the design review earlier. Just as a point of clarification you mean, the design review comes after pr is QA tested is that what you mean?

mariia-skrypnyk · 2024-01-14T14:16:46Z

@mariia-skrypnyk I may have just missed a step and involved the design review earlier. Just as a point of clarification you mean, the design review comes after pr is QA tested is that what you mean?

Thanks @jo-mut for your comment. Yes, if you PR needs a design review this step comes after QA's testing. We involve designers by dragging the card to the Design review column. You can find all this described in this doc here.

jo-mut changed the title ~~fixed dark border around the community logo on community page~~ fixed dark border around the community logo Dec 28, 2023

jo-mut self-assigned this Dec 28, 2023

jo-mut requested review from ilmotta, vkjr, siddarthkay, Parveshdhull and ajayesivan December 28, 2023 12:23

Parveshdhull reviewed Dec 28, 2023

View reviewed changes

src/status_im/common/scroll_page/style.cljs Outdated Show resolved Hide resolved

Parveshdhull approved these changes Dec 28, 2023

View reviewed changes

jo-mut force-pushed the bug/community-logo-dark-border branch 2 times, most recently from 83c4990 to 9d3303d Compare December 29, 2023 13:56

siddarthkay approved these changes Dec 30, 2023

View reviewed changes

ajayesivan approved these changes Jan 1, 2024

View reviewed changes

jo-mut force-pushed the bug/community-logo-dark-border branch 2 times, most recently from a5b088c to 63f9156 Compare January 2, 2024 15:08

jo-mut force-pushed the bug/community-logo-dark-border branch 2 times, most recently from 5b12fe2 to 51f5f14 Compare January 8, 2024 21:29

jo-mut added the request-manual-qa label Jan 11, 2024

jo-mut force-pushed the bug/community-logo-dark-border branch from 51f5f14 to 2e9c95e Compare January 12, 2024 10:25

mariia-skrypnyk self-assigned this Jan 12, 2024

mariia-skrypnyk added the Tested - OK label Jan 12, 2024

fixed dark border around the community logo on community page

965aadb

jo-mut force-pushed the bug/community-logo-dark-border branch from 2e9c95e to 965aadb Compare January 12, 2024 17:22

jo-mut merged commit 6aa981d into develop Jan 12, 2024
6 checks passed

jo-mut deleted the bug/community-logo-dark-border branch January 12, 2024 17:37

fixed dark border around the community logo #18314

fixed dark border around the community logo #18314

Conversation

jo-mut commented Dec 28, 2023

status-im-auto commented Dec 28, 2023 • edited Loading

Jenkins Builds

status-im-auto commented Dec 28, 2023

50% of end-end tests have passed

Failed tests (20)

Class TestCommunityMultipleDeviceMerged:

Class TestActivityMultipleDevicePRTwo:

Class TestActivityMultipleDevicePR:

Class TestCommunityMultipleDeviceMergedTwo:

Expected to fail tests (4)

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestGroupChatMultipleDeviceMergedNewUI:

Passed tests (24)

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestDeepLinksOneDevice:

status-im-auto commented Dec 28, 2023

88% of end-end tests have passed

Failed tests (1)

Class TestCommunityMultipleDeviceMergedTwo:

Expected to fail tests (5)

Class TestCommunityMultipleDeviceMergedTwo:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Passed tests (42)

Class TestDeepLinksOneDevice:

Class TestActivityMultipleDevicePR:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestCommunityOneDeviceMerged:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestCommunityMultipleDeviceMerged:

Class TestActivityMultipleDevicePRTwo:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

jo-mut commented Jan 4, 2024

Francesca-G commented Jan 5, 2024

mariia-skrypnyk commented Jan 12, 2024 • edited Loading

jo-mut commented Jan 12, 2024 • edited Loading

mariia-skrypnyk commented Jan 14, 2024 • edited Loading

status-im-auto commented Dec 28, 2023 •

edited

Loading

mariia-skrypnyk commented Jan 12, 2024 •

edited

Loading

jo-mut commented Jan 12, 2024 •

edited

Loading

mariia-skrypnyk commented Jan 14, 2024 •

edited

Loading