Wallet: loading routes #18279
Closed
Wallet: loading routes #18279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins Builds
|
OmarBasem
force-pushed
the
wallet/loading-routes-ui
branch
from
ffef56d to
cadd2d7
Compare
OmarBasem
requested review from
vkjr,
briansztamfater,
smohamedjavid and
mmilad75
Comment on lines
+47
to
+55
| [routes | ||
| {:amount amount | ||
| :status :default | ||
| :from-network from-network | ||
| :to-network to-network}] | ||
| [routes | ||
| {:status :loading | ||
| :from-network (:network-name (nth (seq networks) 1)) | ||
| :to-network (:network-name (nth (seq networks) 1))}]))])) |
There was a problem hiding this comment.
Maybe we can simplify this code by having one routes element and set the corresponding value of from-network, to-network, status and amount in the let bindings
Comment on lines
+42
to
+44
| {:content-container-style {:flex-grow 1 | ||
| :align-items :center | ||
| :justify-content :center}} |
There was a problem hiding this comment.
We should set this style in a styles file
|
@OmarBasem thanks for your PR! Can you please rebase and fix linting? |
I think we should have some input from the design team on how we should handle this. By now I think it is okay?, but probably they can come up with an elegant solution to this. cc @mariocnovoa @pedro-et |
briansztamfater
approved these changes
Dec 27, 2023
42% of end-end tests have passedFailed tests (24)Click to expandClass TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePR:
Expected to fail tests (4)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Passed tests (20)Click to expandClass TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestDeepLinksOneDevice:
|
J-Son89
reviewed
Jan 4, 2024
| @@ -8,7 +8,7 @@ | |||
| [token] | |||
| (let [token-symbol (cond-> token | |||
| (keyword? token) name | |||
| :always (comp string/lower-case str))] | |||
| :always string/lower-case)] | |||
There was a problem hiding this comment.
I thought @ulisesmac recently handled this? is there still issues here? 🤔
There was a problem hiding this comment.
@J-Son89 these are old changes. Not relevant anymore.
|
To be followed in: #18491 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #18278
This PR implements loading routes UI in wallet send flow.
A few points that needs consideration:
The loading routes UI assumes that we know in advance what are the possible routes, but that's not the case. We first need to fetch the routes then display them.
Currently, we display the best route only. I have noticed that the best route is usually the first network after mainnet, so in this PR I am assuming this will be the best route while in loading state. But is there a way to know/calculate these routes in advance. Especially that later on we want to display all the possible routes, not just the best route.
On Desktop app, it only displays a loading indicator while loading the routes, so maybe on mobile we should do the same?
Designs
Demo:
https://github.com/status-im/status-mobile/assets/29354102/2d3510f7-6d3a-4816-a29c-d7bb2b79bb8e