Wallet: receive screen #18167
Merged
Wallet: receive screen #18167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (46)
|
OmarBasem
requested review from
vkjr,
briansztamfater,
smohamedjavid,
J-Son89,
mmilad75 and
ulisesmac
vkjr
reviewed
Dec 13, 2023
vkjr
reviewed
Dec 13, 2023
vkjr
reviewed
Dec 13, 2023
vkjr
reviewed
Dec 13, 2023
vkjr
reviewed
Dec 13, 2023
vkjr
reviewed
Dec 13, 2023
|
Related to the UI change in QR code, there's a PR addressing it: So, it's better not to add a conflict in case this PR gets merged first. Wdyt? |
Sounds good 👍 |
OmarBasem
force-pushed
the
wallet/receive-screen
branch
from
82ff61b to
941eef1
Compare
|
Thanks for your review @vkjr, fixed the issues 👍 |
|
#18159 has been closed and not relevant to this PR anymore |
J-Son89
reviewed
Dec 18, 2023
src/status_im2/contexts/wallet/common/sheets/network_preferences/style.cljs
Outdated
Show resolved
Hide resolved
J-Son89
reviewed
Dec 18, 2023
J-Son89
reviewed
Dec 18, 2023
J-Son89
reviewed
Dec 18, 2023
J-Son89
reviewed
Dec 18, 2023
OmarBasem
force-pushed
the
wallet/receive-screen
branch
from
63954db to
3d1a3dd
Compare
|
@OmarBasem there is a convention to run e2e in each PR, please follow it. |
I moved the PR to e2e but it seems it did not run. Did not notice that. Apologies. |
|
tag us next time or just use https://ci.status.im/job/status-mobile/job/e2e/job/status-app-prs-rerun/build?delay=0sec, where you need to put Pr ID and link to apk e2e, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #18152
This PR implements receive screen, and some updates to the Share QR Code component to match recent updates to the designs.
2 Notes regarding UI that are out of scope:
Designs
Demo:
IMG_3985.mp4