Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ROW_NUMBER() not work on ios for some reason #16426

Merged
merged 4 commits into from
Jun 29, 2023
Merged

fix: ROW_NUMBER() not work on ios for some reason #16426

merged 4 commits into from
Jun 29, 2023

Conversation

qfrank
Copy link
Contributor

@qfrank qfrank commented Jun 28, 2023

fixes #16421

status: ready

@qfrank
Copy link
Contributor Author

qfrank commented Jun 28, 2023

cc @churik @pavloburykh

@status-im-auto
Copy link
Member

status-im-auto commented Jun 28, 2023

Jenkins Builds

Click to see older builds (7)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 6893a81 #1 2023-06-28 13:14:36 ~9 min android-e2e 🤖apk 📲
✔️ 6893a81 #1 2023-06-28 13:15:26 ~10 min android 🤖apk 📲
✔️ 6893a81 #1 2023-06-28 13:17:47 ~12 min ios 📱ipa 📲
✔️ e52e062 #2 2023-06-28 14:12:37 ~9 min android-e2e 🤖apk 📲
✔️ e52e062 #2 2023-06-28 14:13:20 ~9 min android 🤖apk 📲
✔️ e52e062 #2 2023-06-28 14:15:25 ~11 min tests 📄log
✔️ e52e062 #2 2023-06-28 14:22:36 ~19 min ios 📱ipa 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ ce3e272 #3 2023-06-29 07:42:57 ~8 min android-e2e 🤖apk 📲
✔️ ce3e272 #3 2023-06-29 07:43:38 ~9 min android 🤖apk 📲
✔️ ce3e272 #3 2023-06-29 07:45:03 ~10 min tests 📄log
✔️ ce3e272 #3 2023-06-29 07:57:48 ~23 min ios 📱ipa 📲
✔️ 3a46dde #4 2023-06-29 11:00:48 ~8 min tests 📄log
✔️ 3a46dde #4 2023-06-29 11:01:41 ~9 min android-e2e 🤖apk 📲
✔️ 3a46dde #4 2023-06-29 11:03:30 ~11 min android 🤖apk 📲
✔️ 3a46dde #4 2023-06-29 11:06:31 ~14 min ios 📱ipa 📲

@pavloburykh pavloburykh self-assigned this Jun 28, 2023
@pavloburykh
Copy link
Contributor

cc @churik @pavloburykh

thank you @qfrank! Waiting for review and approval of go PR status-im/status-go#3687

@pavloburykh
Copy link
Contributor

pavloburykh commented Jun 28, 2023

@qfrank still unable to log in. Now receiving error both on IOS and Android

ISSUE 1 "failed to create bindata migration source..." error on login

Steps:

  1. Proceed with creation of a new account (user will get stucked on Generating keys screen)
  2. Reopen the app
  3. Try to login multiaccount
  4. Observe an error

Actual result: "failed to create bindata migration source..." error on login

photo_2023-06-28 16 31 48

@qfrank
Copy link
Contributor Author

qfrank commented Jun 28, 2023

emm.. shouldn't be, maybe because i rebased with latest develop, let me try to reproduce

@qfrank
Copy link
Contributor Author

qfrank commented Jun 28, 2023

pls retry with the latest commit, thank you @pavloburykh

@pavloburykh
Copy link
Contributor

@qfrank thank you for the fix! Now I am able to login multiaccount on both IOS and Android. Please take a look at the new issues.

ISSUE 2 Unable to perform manual backup

Steps:

  1. Open backup settings: profile => sync settings => backup settings
  2. Tap Perform backup button
  3. See if backup has been performed

Actual result: backup has not been performed

Status-debug-logs (36).zip

telegram-cloud-document-2-5251307327130185019.mp4

@pavloburykh
Copy link
Contributor

ISSUE 3 Sync results in errors on both sides

Steps:

  1. User A generates sync QR
  2. User B scans QR
  3. Observe the result

Actual result: sync failed. User A an User B observe following errors

User A: "no such column:include_watch_only_account"

photo_2023-06-28 17 39 52

User B:"[client] status not ok when receiving sync device data, received 500 Internal Error'

photo_2023-06-28 17 39 54

@qfrank
Copy link
Contributor Author

qfrank commented Jun 28, 2023

Hi @pavloburykh , issue 2-3 should not be relate to this PR, it's relate to this one, we can fix it in a separate PR. WDYT?

@status-im-auto
Copy link
Member

58% of end-end tests have passed

Total executed tests: 33
Failed tests: 14
Passed tests: 19
IDs of failed tests: 703133,702732,702947,702894,702936,702851,702786,702850,702957,702731,702807,702958,702745,702808 

Failed tests (14)

Click to expand
  • Rerun failed tests

  • Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Test setup failed: medium/test_activity_center.py:14: in prepare_devices
        self.drivers, self.loop = create_shared_drivers(2)
    base_test_case.py:308: in create_shared_drivers
        test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
     '_asyncio.Future' object has no attribute 'session_id'
    



    2. test_activity_center_contact_request_decline, id: 702850

    Test setup failed: medium/test_activity_center.py:14: in prepare_devices
        self.drivers, self.loop = create_shared_drivers(2)
    base_test_case.py:308: in create_shared_drivers
        test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
     '_asyncio.Future' object has no attribute 'session_id'
    



    Class TestActivityMultipleDevicePR:

    1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947

    Test setup failed: medium/test_activity_center.py:124: in prepare_devices
        self.drivers, self.loop = create_shared_drivers(2)
    base_test_case.py:308: in create_shared_drivers
        test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
     '_asyncio.Future' object has no attribute 'session_id'
    



    2. test_navigation_jump_to, id: 702936

    Test setup failed: medium/test_activity_center.py:124: in prepare_devices
        self.drivers, self.loop = create_shared_drivers(2)
    base_test_case.py:308: in create_shared_drivers
        test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
     '_asyncio.Future' object has no attribute 'session_id'
    



    3. test_activity_center_mentions, id: 702957

    Test setup failed: medium/test_activity_center.py:124: in prepare_devices
        self.drivers, self.loop = create_shared_drivers(2)
    base_test_case.py:308: in create_shared_drivers
        test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
     '_asyncio.Future' object has no attribute 'session_id'
    



    4. test_activity_center_admin_notification_accept_swipe, id: 702958

    Test setup failed: medium/test_activity_center.py:124: in prepare_devices
        self.drivers, self.loop = create_shared_drivers(2)
    base_test_case.py:308: in create_shared_drivers
        test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
     '_asyncio.Future' object has no attribute 'session_id'
    



    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731

    Test is not run, e2e blocker  
    

    [[reason: [NOTRUN] Pin feature is in development]]

    2. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

    Device 2: Find MemberPhoto by xpath: //*[starts-with(@text,'profile_photo')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='user-avatar']
    Device 2: Image differs from template to 5.130543428308823 percents

    critical/chats/test_1_1_public_chats.py:1076: in test_1_1_chat_non_latin_messages_stack_update_profile_photo
        self.errors.verify_no_errors()
    base_test_case.py:182: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     Image of user in 1-1 chat is too different from template!
    



    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732

    Test is not run, e2e blocker  
    

    [[reason: [NOTRUN] Pin feature is in development]]

    2. test_group_chat_join_send_text_messages_push, id: 702807

    Test setup failed: critical/chats/test_group_chat.py:148: in prepare_devices
        self.drivers, self.loop = create_shared_drivers(3)
    base_test_case.py:308: in create_shared_drivers
        test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
     '_asyncio.Future' object has no attribute 'session_id'
    



    3. test_group_chat_offline_pn, id: 702808

    Test setup failed: critical/chats/test_group_chat.py:148: in prepare_devices
        self.drivers, self.loop = create_shared_drivers(3)
    base_test_case.py:308: in create_shared_drivers
        test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
     '_asyncio.Future' object has no attribute 'session_id'
    



    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    Device 1: Tap on found: ProfileSendMessageButton
    Device 1: Find Text by xpath: //*[@content-desc='user-avatar']/../following-sibling::android.widget.TextView

    critical/test_public_chat_browsing.py:391: in test_restore_multiaccount_with_waku_backup_remove_switch
        shown_name_text = chat.user_name_text_new_UI.text
    ../views/base_element.py:391: in text
        text = self.find_element().text
    ../views/base_element.py:80: in find_element
        raise NoSuchElementException(
     Device 1: Text by xpath: `//*[@content-desc='user-avatar']/../following-sibling::android.widget.TextView` is not found on the screen
    



    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_contact_block_unblock_offline, id: 702894

    Device 2: Type I should not be in chat to ChatMessageInput
    Device 2: Find SendMessageButton by accessibility id: send-message-button

    critical/test_public_chat_browsing.py:734: in test_community_contact_block_unblock_offline
        self.channel_2.send_message(message_to_disappear)
    ../views/chat_view.py:963: in send_message
        self.send_message_button.click()
    ../views/base_element.py:91: in click
        self.find_element().click()
    ../views/base_element.py:80: in find_element
        raise NoSuchElementException(
     Device 2: SendMessageButton by accessibility id: `send-message-button` is not found on the screen
    



    Device sessions

    2. test_community_mentions_push_notification, id: 702786

    # STEP: Admin gets push notification with the mention and tap it
    Device 1: Getting PN by 'user_1'

    critical/test_public_chat_browsing.py:906: in test_community_mentions_push_notification
        self.errors.verify_no_errors()
    base_test_case.py:182: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     Push notification with the mention was not received by admin
    



    Device sessions

    Passed tests (19)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_message_delete, id: 702839
    Device sessions

    3. test_community_leave, id: 702845
    Device sessions

    4. test_community_one_image_send_reply, id: 702859
    Device sessions

    5. test_community_message_edit, id: 702843
    Device sessions

    6. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    7. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    8. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    9. test_community_unread_messages_badge, id: 702841
    Device sessions

    10. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    4. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    7. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    @status-im-auto
    Copy link
    Member

    9% of end-end tests have passed

    Total executed tests: 33
    Failed tests: 30
    Passed tests: 3
    
    IDs of failed tests: 702807,702732,702783,702745,702841,702851,702733,702936,702855,702844,702731,703194,702838,702843,702839,702957,702958,702730,702947,702784,702813,703086,702859,702808,702786,702850,702840,702782,702894,702845 
    

    Failed tests (30)

    Click to expand
  • Rerun failed tests

  • Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Test setup failed: critical/chats/test_1_1_public_chats.py:832: in prepare_devices
        self.drivers, self.loop = create_shared_drivers(2)
    base_test_case.py:308: in create_shared_drivers
        test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
     '_asyncio.Future' object has no attribute 'session_id'
    



    2. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

    Test setup failed: critical/chats/test_1_1_public_chats.py:832: in prepare_devices
        self.drivers, self.loop = create_shared_drivers(2)
    base_test_case.py:308: in create_shared_drivers
        test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
     '_asyncio.Future' object has no attribute 'session_id'
    



    3. test_1_1_chat_text_message_delete_push_disappear, id: 702733

    Test setup failed: critical/chats/test_1_1_public_chats.py:832: in prepare_devices
        self.drivers, self.loop = create_shared_drivers(2)
    base_test_case.py:308: in create_shared_drivers
        test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
     '_asyncio.Future' object has no attribute 'session_id' 
    

    [[Message is being in status 'Sending' for a long time: https://github.com//issues/15385]]

    4. test_1_1_chat_edit_message, id: 702855

    Test setup failed: critical/chats/test_1_1_public_chats.py:832: in prepare_devices
        self.drivers, self.loop = create_shared_drivers(2)
    base_test_case.py:308: in create_shared_drivers
        test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
     '_asyncio.Future' object has no attribute 'session_id' 
    

    [[Message is being in status 'Sending' for a long time: https://github.com//issues/15385]]

    5. test_1_1_chat_pin_messages, id: 702731

    Test is not run, e2e blocker  
    

    [[reason: [NOTRUN] Pin feature is in development]]

    6. test_1_1_chat_message_reaction, id: 702730

    Test setup failed: critical/chats/test_1_1_public_chats.py:832: in prepare_devices
        self.drivers, self.loop = create_shared_drivers(2)
    base_test_case.py:308: in create_shared_drivers
        test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
     '_asyncio.Future' object has no attribute 'session_id'
    



    7. test_1_1_chat_delete_via_long_press_relogin, id: 702784

    Test setup failed: critical/chats/test_1_1_public_chats.py:832: in prepare_devices
        self.drivers, self.loop = create_shared_drivers(2)
    base_test_case.py:308: in create_shared_drivers
        test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
     '_asyncio.Future' object has no attribute 'session_id'
    



    8. test_1_1_chat_push_emoji, id: 702813

    Test setup failed: critical/chats/test_1_1_public_chats.py:832: in prepare_devices
        self.drivers, self.loop = create_shared_drivers(2)
    base_test_case.py:308: in create_shared_drivers
        test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
     '_asyncio.Future' object has no attribute 'session_id'
    



    9. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782

    Test setup failed: critical/chats/test_1_1_public_chats.py:832: in prepare_devices
        self.drivers, self.loop = create_shared_drivers(2)
    base_test_case.py:308: in create_shared_drivers
        test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
     '_asyncio.Future' object has no attribute 'session_id'
    



    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851

    Test setup failed: medium/test_activity_center.py:14: in prepare_devices
        self.drivers, self.loop = create_shared_drivers(2)
    base_test_case.py:308: in create_shared_drivers
        test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
     '_asyncio.Future' object has no attribute 'session_id'
    



    2. test_activity_center_contact_request_decline, id: 702850

    Test setup failed: medium/test_activity_center.py:14: in prepare_devices
        self.drivers, self.loop = create_shared_drivers(2)
    base_test_case.py:308: in create_shared_drivers
        test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
     '_asyncio.Future' object has no attribute 'session_id'
    



    Class TestCommunityMultipleDeviceMerged:

    1. test_community_unread_messages_badge, id: 702841

    Test setup failed: critical/test_public_chat_browsing.py:439: in prepare_devices
        self.drivers, self.loop = create_shared_drivers(2)
    base_test_case.py:308: in create_shared_drivers
        test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
     '_asyncio.Future' object has no attribute 'session_id'
    



    2. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844

    Test setup failed: critical/test_public_chat_browsing.py:439: in prepare_devices
        self.drivers, self.loop = create_shared_drivers(2)
    base_test_case.py:308: in create_shared_drivers
        test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
     '_asyncio.Future' object has no attribute 'session_id'
    



    3. test_community_several_images_send_reply, id: 703194

    Test setup failed: critical/test_public_chat_browsing.py:439: in prepare_devices
        self.drivers, self.loop = create_shared_drivers(2)
    base_test_case.py:308: in create_shared_drivers
        test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
     '_asyncio.Future' object has no attribute 'session_id'
    



    4. test_community_message_send_check_timestamps_sender_username, id: 702838

    Test setup failed: critical/test_public_chat_browsing.py:439: in prepare_devices
        self.drivers, self.loop = create_shared_drivers(2)
    base_test_case.py:308: in create_shared_drivers
        test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
     '_asyncio.Future' object has no attribute 'session_id'
    



    5. test_community_message_edit, id: 702843

    Test setup failed: critical/test_public_chat_browsing.py:439: in prepare_devices
        self.drivers, self.loop = create_shared_drivers(2)
    base_test_case.py:308: in create_shared_drivers
        test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
     '_asyncio.Future' object has no attribute 'session_id'
    



    6. test_community_message_delete, id: 702839

    Test setup failed: critical/test_public_chat_browsing.py:439: in prepare_devices
        self.drivers, self.loop = create_shared_drivers(2)
    base_test_case.py:308: in create_shared_drivers
        test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
     '_asyncio.Future' object has no attribute 'session_id'
    



    7. test_community_mark_all_messages_as_read, id: 703086

    Test setup failed: critical/test_public_chat_browsing.py:439: in prepare_devices
        self.drivers, self.loop = create_shared_drivers(2)
    base_test_case.py:308: in create_shared_drivers
        test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
     '_asyncio.Future' object has no attribute 'session_id'
    



    8. test_community_one_image_send_reply, id: 702859

    Test setup failed: critical/test_public_chat_browsing.py:439: in prepare_devices
        self.drivers, self.loop = create_shared_drivers(2)
    base_test_case.py:308: in create_shared_drivers
        test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
     '_asyncio.Future' object has no attribute 'session_id'
    



    9. test_community_mentions_push_notification, id: 702786

    Test setup failed: critical/test_public_chat_browsing.py:439: in prepare_devices
        self.drivers, self.loop = create_shared_drivers(2)
    base_test_case.py:308: in create_shared_drivers
        test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
     '_asyncio.Future' object has no attribute 'session_id'
    



    10. test_community_emoji_send_copy_paste_reply, id: 702840

    Test setup failed: critical/test_public_chat_browsing.py:439: in prepare_devices
        self.drivers, self.loop = create_shared_drivers(2)
    base_test_case.py:308: in create_shared_drivers
        test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
     '_asyncio.Future' object has no attribute 'session_id'
    



    11. test_community_contact_block_unblock_offline, id: 702894

    Test setup failed: critical/test_public_chat_browsing.py:439: in prepare_devices
        self.drivers, self.loop = create_shared_drivers(2)
    base_test_case.py:308: in create_shared_drivers
        test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
     '_asyncio.Future' object has no attribute 'session_id'
    



    12. test_community_leave, id: 702845

    Test setup failed: critical/test_public_chat_browsing.py:439: in prepare_devices
        self.drivers, self.loop = create_shared_drivers(2)
    base_test_case.py:308: in create_shared_drivers
        test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
     '_asyncio.Future' object has no attribute 'session_id'
    



    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807

    Test setup failed: critical/chats/test_group_chat.py:148: in prepare_devices
        self.drivers, self.loop = create_shared_drivers(3)
    base_test_case.py:308: in create_shared_drivers
        test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
     '_asyncio.Future' object has no attribute 'session_id'
    



    2. test_group_chat_pin_messages, id: 702732

    Test is not run, e2e blocker  
    

    [[reason: [NOTRUN] Pin feature is in development]]

    3. test_group_chat_offline_pn, id: 702808

    Test setup failed: critical/chats/test_group_chat.py:148: in prepare_devices
        self.drivers, self.loop = create_shared_drivers(3)
    base_test_case.py:308: in create_shared_drivers
        test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
     '_asyncio.Future' object has no attribute 'session_id'
    



    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936

    Test setup failed: medium/test_activity_center.py:124: in prepare_devices
        self.drivers, self.loop = create_shared_drivers(2)
    base_test_case.py:308: in create_shared_drivers
        test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
     '_asyncio.Future' object has no attribute 'session_id'
    



    2. test_activity_center_mentions, id: 702957

    Test setup failed: medium/test_activity_center.py:124: in prepare_devices
        self.drivers, self.loop = create_shared_drivers(2)
    base_test_case.py:308: in create_shared_drivers
        test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
     '_asyncio.Future' object has no attribute 'session_id'
    



    3. test_activity_center_admin_notification_accept_swipe, id: 702958

    Test setup failed: medium/test_activity_center.py:124: in prepare_devices
        self.drivers, self.loop = create_shared_drivers(2)
    base_test_case.py:308: in create_shared_drivers
        test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
     '_asyncio.Future' object has no attribute 'session_id'
    



    4. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947

    Test setup failed: medium/test_activity_center.py:124: in prepare_devices
        self.drivers, self.loop = create_shared_drivers(2)
    base_test_case.py:308: in create_shared_drivers
        test_suite_data.current_test.testruns[-1].jobs[drivers[i].session_id] = i + 1
     '_asyncio.Future' object has no attribute 'session_id'
    



    Passed tests (3)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    3. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    @pavloburykh
    Copy link
    Contributor

    pavloburykh commented Jun 29, 2023

    @qfrank thank you! ISSUEs 2 and 3 are fixed.

    Though, I am experiencing troubles with pairing:

    1. IOS is crashing after scanning sync QR
    2. Data is not being updated between pairing devices (or updating takes a long time)
    sync_pairing.mp4

    Android_sync_log.zip
    IOS_sync.zip

    These issues will be addressed in followup after merging of this PR.

    @qfrank I am still waiting for the results of e2e re-run. Will ping you when PR will be ready for merge

    @qfrank
    Copy link
    Contributor Author

    qfrank commented Jun 29, 2023

    I think we can merge the PR first so that it won't block other ppl to create new account ... any other issue should not be relate to my fix... my fix is simple, also I got information from @cammellos , he said we changed the way we run tests in status-go, so there could be more issues comes out, I found new PRs (e.g. this one ) for status-go can be merged without pass test(run test in local will fail, but CI will ignore the failure)... that's why issue 2-3 comes out...
    @cammellos is working on this PR status-im/status-go#3696 to fix the way we run test

    @status-im-auto
    Copy link
    Member

    73% of end-end tests have passed

    Total executed tests: 33
    Failed tests: 9
    Passed tests: 24
    
    IDs of failed tests: 702783,702850,702958,702732,702851,702894,702731,702745,703133 
    

    Failed tests (9)

    Click to expand
  • Rerun failed tests

  • Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

    # STEP: Device1 goes back online and checks that 1-1 chat will be fetched
    Device 1: Looking for a message by text: test message

    critical/chats/test_1_1_public_chats.py:1251: in test_1_1_chat_is_shown_message_sent_delivered_from_offline
        self.errors.verify_no_errors()
    base_test_case.py:182: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     Message status was not changed to Delivered, it's Sent after back up online!
    



    Device sessions

    2. test_1_1_chat_pin_messages, id: 702731

    Test is not run, e2e blocker  
    

    [[reason: [NOTRUN] Pin feature is in development]]

    3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745

    Device 2: Find MemberPhoto by xpath: //*[starts-with(@text,'profile_photo')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='user-avatar']
    Device 2: Image differs from template to 5.263671875 percents

    critical/chats/test_1_1_public_chats.py:1076: in test_1_1_chat_non_latin_messages_stack_update_profile_photo
        self.errors.verify_no_errors()
    base_test_case.py:182: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     Image of user in 1-1 chat is too different from template!
    



    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732

    Test is not run, e2e blocker  
    

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850

    Device 2: Tap on found: Button
    Device 2: Looking for activity center element: 'sender'

    medium/test_activity_center.py:73: in test_activity_center_contact_request_decline
        message_element.wait_for_element(30)
    ../views/base_element.py:117: in wait_for_element
        raise TimeoutException(
     Device `2`: `Button` by` xpath`: `//*[contains(@text, 'sender')]/ancestor::*[@content-desc='activity']//*[@content-desc="activity-message-body"]` is not found on the screen after wait_for_element
    



    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851

    Device 2: Find Button by accessibility id: new-chat-button
    Device 2: Find Button by accessibility id: add-a-contact

    medium/test_activity_center.py:87: in test_activity_center_contact_request_accept_swipe_mark_all_as_read
        self.home_2.add_contact(self.public_key_1, remove_from_contacts=True)
    ../views/home_view.py:359: in add_contact
        self.add_a_contact_chat_bottom_sheet_button.click()
    ../views/base_element.py:91: in click
        self.find_element().click()
    ../views/base_element.py:80: in find_element
        raise NoSuchElementException(
     Device 2: Button by accessibility id: `add-a-contact` is not found on the screen
    



    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    Device 1: Tap on found: ProfileSendMessageButton
    Device 1: Find Text by xpath: //*[@content-desc='user-avatar']/../following-sibling::android.widget.TextView

    critical/test_public_chat_browsing.py:391: in test_restore_multiaccount_with_waku_backup_remove_switch
        shown_name_text = chat.user_name_text_new_UI.text
    ../views/base_element.py:391: in text
        text = self.find_element().text
    ../views/base_element.py:80: in find_element
        raise NoSuchElementException(
     Device 1: Text by xpath: `//*[@content-desc='user-avatar']/../following-sibling::android.widget.TextView` is not found on the screen
    



    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_activity_center_admin_notification_accept_swipe, id: 702958

    Device 1: Looking for activity center element: 'user2'
    Device 1: Find Button by xpath: //*[contains(@text, 'user2')]/ancestor::*[@content-desc='activity']//*[@content-desc="activity-title"]

    medium/test_activity_center.py:331: in test_activity_center_admin_notification_accept_swipe
        if reply_element.title.text != 'Join request':
    ../views/base_element.py:209: in text
        return self.find_element().text
    ../views/base_element.py:80: in find_element
        raise NoSuchElementException(
     Device 1: Button by xpath: `//*[contains(@text, 'user2')]/ancestor::*[@content-desc='activity']//*[@content-desc="activity-title"]` is not found on the screen
    



    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_contact_block_unblock_offline, id: 702894

    Device 1: Find ProfileSendMessageButton by accessibility id: Chat-item-button
    Device 1: Sending message 'piy'

    critical/test_public_chat_browsing.py:810: in test_community_contact_block_unblock_offline
        self.errors.verify_no_errors()
    base_test_case.py:182: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     Chat with unblocked user was not enabled after 1 minute
    



    Device sessions

    Passed tests (24)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    2. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    4. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    5. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    6. test_1_1_chat_edit_message, id: 702855
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_mentions, id: 702957
    Device sessions

    3. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    2. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    3. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    4. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    5. test_community_message_edit, id: 702843
    Device sessions

    6. test_community_message_delete, id: 702839
    Device sessions

    7. test_community_unread_messages_badge, id: 702841
    Device sessions

    8. test_community_mentions_push_notification, id: 702786
    Device sessions

    9. test_community_one_image_send_reply, id: 702859
    Device sessions

    10. test_community_several_images_send_reply, id: 703194
    Device sessions

    11. test_community_leave, id: 702845
    Device sessions

    @pavloburykh
    Copy link
    Contributor

    @qfrank failed e2e are not PR related. Ready for merge. Thank you for your work!

    @qfrank qfrank merged commit a7ddda4 into develop Jun 29, 2023
    @qfrank qfrank deleted the fix/16421 branch June 29, 2023 11:11
    @pavloburykh pavloburykh mentioned this pull request Jun 29, 2023
    codemaster115 pushed a commit that referenced this pull request Jul 7, 2023
    status-im/status-go@6705042...09c5223
    
    * fix: ROW_NUMBER() not work on ios for some reason
    
    * update status-go-version.json
    
    * update status-go-version.json
    
    * update status-go-version.json
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    No open projects
    Archived in project
    Development

    Successfully merging this pull request may close these issues.

    "DB is dirty after migration..." error on login by newly created user [IOS]
    4 participants