-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ROW_NUMBER() not work on ios for some reason #16426
Conversation
Jenkins BuildsClick to see older builds (7)
|
thank you @qfrank! Waiting for review and approval of go PR status-im/status-go#3687 |
@qfrank still unable to log in. Now receiving error both on IOS and Android ISSUE 1 "failed to create bindata migration source..." error on loginSteps:
Actual result: "failed to create bindata migration source..." error on login |
emm.. shouldn't be, maybe because i rebased with latest |
pls retry with the latest commit, thank you @pavloburykh |
@qfrank thank you for the fix! Now I am able to login multiaccount on both IOS and Android. Please take a look at the new issues. ISSUE 2 Unable to perform manual backupSteps:
Actual result: backup has not been performed telegram-cloud-document-2-5251307327130185019.mp4 |
ISSUE 3 Sync results in errors on both sidesSteps:
Actual result: sync failed. User A an User B observe following errors User A: "no such column:include_watch_only_account" User B:"[client] status not ok when receiving sync device data, received 500 Internal Error' |
Hi @pavloburykh , issue 2-3 should not be relate to this PR, it's relate to this one, we can fix it in a separate PR. WDYT? |
58% of end-end tests have passed
Failed tests (14)Click to expandClass TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Passed tests (19)Click to expandClass TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
9% of end-end tests have passed
Failed tests (30)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
Passed tests (3)Click to expandClass TestCommunityOneDeviceMerged:
|
@qfrank thank you! ISSUEs 2 and 3 are fixed. Though, I am experiencing troubles with pairing:
sync_pairing.mp4Android_sync_log.zip These issues will be addressed in followup after merging of this PR. @qfrank I am still waiting for the results of e2e re-run. Will ping you when PR will be ready for merge |
I think we can merge the PR first so that it won't block other ppl to create new account ... any other issue should not be relate to my fix... my fix is simple, also I got information from @cammellos , he said we changed the way we run tests in status-go, so there could be more issues comes out, I found new PRs (e.g. this one ) for status-go can be merged without pass test(run test in local will fail, but CI will ignore the failure)... that's why issue 2-3 comes out... |
73% of end-end tests have passed
Failed tests (9)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Passed tests (24)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
|
@qfrank failed e2e are not PR related. Ready for merge. Thank you for your work! |
status-im/status-go@6705042...09c5223 * fix: ROW_NUMBER() not work on ios for some reason * update status-go-version.json * update status-go-version.json * update status-go-version.json
fixes #16421
status: ready