Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16247] Make reactions row scrollable #16298

Merged
merged 3 commits into from
Jun 20, 2023
Merged

[16247] Make reactions row scrollable #16298

merged 3 commits into from
Jun 20, 2023

Conversation

ibrkhalil
Copy link
Contributor

fixes #16247

Summary

Makes the reactions row that shows under messages horizontally scrollable to fix #16247

status: ready

@ibrkhalil ibrkhalil self-assigned this Jun 18, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Jun 18, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (4)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 2396aa9 #1 2023-06-18 08:54:04 ~3 min tests 📄log
✔️ 2396aa9 #1 2023-06-18 08:56:42 ~6 min android 🤖apk 📲
✔️ 2396aa9 #1 2023-06-18 08:57:08 ~6 min ios 📱ipa 📲
✔️ 2396aa9 #1 2023-06-18 09:01:43 ~11 min android-e2e 🤖apk 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 618aeec #2 2023-06-20 09:05:30 ~5 min android-e2e 🤖apk 📲
✔️ 618aeec #2 2023-06-20 09:06:25 ~6 min ios 📱ipa 📲
✔️ 618aeec #2 2023-06-20 09:09:44 ~9 min android 🤖apk 📲
✔️ 618aeec #2 2023-06-20 09:10:03 ~10 min tests 📄log
✔️ c594c7f #3 2023-06-20 16:46:51 ~6 min ios 📱ipa 📲
✔️ c594c7f #3 2023-06-20 16:47:13 ~6 min android-e2e 🤖apk 📲
✔️ c594c7f #3 2023-06-20 16:47:14 ~6 min android 🤖apk 📲
✔️ c594c7f #3 2023-06-20 16:48:54 ~8 min tests 📄log

@qoqobolo
Copy link
Contributor

Hey @ibrkhalil, thanks for PR!
Kindly check the integration tests please, they've failed.

@ibrkhalil
Copy link
Contributor Author

Hey @ibrkhalil, thanks for PR! Kindly check the integration tests please, they've failed.

Done, Thanks!

@qoqobolo qoqobolo self-assigned this Jun 20, 2023
@status-im-auto
Copy link
Member

64% of end-end tests have passed

Total executed tests: 33
Failed tests: 12
Passed tests: 21

IDs of failed tests: 702936,703086,702783,702808,702733,702958,702957,702732,702851,702947,702731,703133

Failed tests (12)

Click to expand
  • Rerun failed tests

    • Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936

    Device 2: Find `Button` by `xpath`: `//*[contains(@text, 'user1')]/ancestor::*[@content-desc='activity']/*[@content-desc="accept-contact-request"]`
    Device 2: Find `Button` by `accessibility id`: `close-activity-center` 

    Test setup failed: medium/test_activity_center.py:136: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:327: in handle_contact_request
    self.close_activity_centre.click()
../views/base_element.py:91: in click
    self.find_element().click()
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 2: Button by accessibility id: `close-activity-center` is not found on the screen



    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958 

    Test setup failed: medium/test_activity_center.py:136: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:327: in handle_contact_request
    self.close_activity_centre.click()
../views/base_element.py:91: in click
    self.find_element().click()
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 2: Button by accessibility id: `close-activity-center` is not found on the screen



    3. test_activity_center_mentions, id: 702957 

    Test setup failed: medium/test_activity_center.py:136: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:327: in handle_contact_request
    self.close_activity_centre.click()
../views/base_element.py:91: in click
    self.find_element().click()
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 2: Button by accessibility id: `close-activity-center` is not found on the screen



    4. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947 

    Test setup failed: medium/test_activity_center.py:136: in prepare_devices
    self.home_2.handle_contact_request(self.username_1)
../views/home_view.py:327: in handle_contact_request
    self.close_activity_centre.click()
../views/base_element.py:91: in click
    self.find_element().click()
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 2: Button by accessibility id: `close-activity-center` is not found on the screen



    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

    # STEP: Device1 goes back online and checks that 1-1 chat will be fetched
    Device 1: Looking for a message by text: test message 

    critical/chats/test_1_1_public_chats.py:1253: in test_1_1_chat_is_shown_message_sent_delivered_from_offline
    self.errors.verify_no_errors()
base_test_case.py:182: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message status was not delivered after back up online, it is "Sending"!

    [[Issue with messages not being sent for a long time]]

    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733

    Device 2: Tap on found: Button
    Device 1: Getting PN by 'DELETE ME' 

    critical/chats/test_1_1_public_chats.py:1210: in test_1_1_chat_text_message_delete_push_disappear
    self.errors.verify_no_errors()
base_test_case.py:182: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message status was not changed to 'Delivered' after 60 s

    [[Message is being in status 'Sending' for a long time: https://github.com//issues/15385]]

    Device sessions

    3. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    Device 1: Find Button by accessibility id: show-profiles
    Device 1: Tap on found: Button 

    critical/test_public_chat_browsing.py:399: in test_restore_multiaccount_with_waku_backup_remove_switch
    self.errors.verify_no_errors()
base_test_case.py:182: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 admin_open was not restored from waku-backup!!
E    member_open was not restored from waku-backup!!
E    admin_closed was not restored from waku-backup!!
E    member_closed was not restored from waku-backup!!
E    Contact Chu_QA was not restored from backup!
E    Contact my-custom-nickname was not restored from backup!



    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_mark_all_messages_as_read, id: 703086

    Device 1: Find Button by accessibility id: mark-as-read
    Device 1: Tap on found: Button 

    critical/test_public_chat_browsing.py:799: in test_community_mark_all_messages_as_read
    self.errors.verify_no_errors()
base_test_case.py:182: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 New messages counter is not shown in home > Commmunity element



    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851

    Device 1: Find ChatsTab by accessibility id: chats-stack-tab
    Device 1: Tap on found: ChatsTab 

    medium/test_activity_center.py:90: in test_activity_center_contact_request_accept_swipe_mark_all_as_read
    self.home_1.notifications_unread_badge.wait_for_visibility_of_element(30)
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 1: BaseElement by accessibility id:`activity-center-unread-count` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_offline_pn, id: 702808

    Device 3: Looking for a message by text: message from old member
    Device 3: Looking for a message by text: message from new member 

    critical/chats/test_group_chat.py:260: in test_group_chat_offline_pn
    self.errors.verify_no_errors()
base_test_case.py:182: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 message from new member if not shown for device 1



    Device sessions

    2. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Passed tests (21)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    2. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    3. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    4. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    5. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    6. test_1_1_chat_edit_message, id: 702855
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    2. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_message_edit, id: 702843
    Device sessions

    5. test_community_message_delete, id: 702839
    Device sessions

    6. test_community_unread_messages_badge, id: 702841
    Device sessions

    7. test_community_mentions_push_notification, id: 702786
    Device sessions

    8. test_community_one_image_send_reply, id: 702859
    Device sessions

    9. test_community_several_images_send_reply, id: 703194
    Device sessions

    10. test_community_leave, id: 702845
    Device sessions

    11. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    @status-im-auto
    Copy link
    Member

    58% of end-end tests have passed

    Total executed tests: 12
Failed tests: 5
Passed tests: 7

    IDs of failed tests: 702783,702808,702732,702731,703133

    Failed tests (5)

    Click to expand
  • Rerun failed tests

    • Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    Device 1: Find `Button` by `accessibility id`: `show-profiles`
    Device 1: Tap on found: Button 

    critical/test_public_chat_browsing.py:399: in test_restore_multiaccount_with_waku_backup_remove_switch
    self.errors.verify_no_errors()
base_test_case.py:182: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 admin_open was not restored from waku-backup!!
E    member_open was not restored from waku-backup!!
E    admin_closed was not restored from waku-backup!!
E    member_closed was not restored from waku-backup!!
E    Contact Chu_QA was not restored from backup!
E    Contact my-custom-nickname was not restored from backup!



    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783

    # STEP: Device1 goes back online and checks that 1-1 chat will be fetched
    Device 1: Looking for a message by text: test message 

    critical/chats/test_1_1_public_chats.py:1253: in test_1_1_chat_is_shown_message_sent_delivered_from_offline
    self.errors.verify_no_errors()
base_test_case.py:182: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message status was not delivered after back up online, it is "Sending"!

    [[Issue with messages not being sent for a long time]]

    Device sessions

    2. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_offline_pn, id: 702808

    Device 2: Find Button by accessibility id: close-activity-center
    Device 2: Tap on found: Button 

    Test setup failed: critical/chats/test_group_chat.py:184: in prepare_devices
    self.loop.run_until_complete(
/usr/lib/python3.10/asyncio/base_events.py:646: in run_until_complete
    return future.result()
__init__.py:36: in run_in_parallel
    returns.append(await k)
/usr/lib/python3.10/concurrent/futures/thread.py:58: in run
    result = self.fn(*self.args, **self.kwargs)
../views/home_view.py:327: in handle_contact_request
    self.close_activity_centre.click()
../views/base_element.py:91: in click
    self.find_element().click()
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 3: Button by accessibility id: `close-activity-center` is not found on the screen



    Device sessions

    2. test_group_chat_pin_messages, id: 702732 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Passed tests (7)

    Click to expand

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    3. test_activity_center_mentions, id: 702957
    Device sessions

    4. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    @qoqobolo
    Copy link
    Contributor

    Thanks a lot for the fix @ibrkhalil!
    PR can be merged.

    @ibrkhalil ibrkhalil merged commit 769d974 into develop Jun 20, 2023
    @ibrkhalil ibrkhalil deleted the 16247 branch June 20, 2023 16:50
    codemaster115 pushed a commit that referenced this pull request Jul 7, 2023
    @ibrkhalil @codemaster115
    Make reactions row scrollable (#16298)
    19944fe
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @flexsurfer flexsurfer flexsurfer approved these changes

    @OmarBasem OmarBasem Awaiting requested review from OmarBasem

    Assignees

    @ibrkhalil ibrkhalil

    @qoqobolo qoqobolo

    Labels
    request-manual-qa Tested - OK
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    The "Add reaction" button in reaction section overflows if a message has all six reaction
    4 participants
    @ibrkhalil @status-im-auto @qoqobolo @flexsurfer