Account selection: error and app freezing when deselecting account one by one

[qoqobolo]

Bug Report

Problem

11111video_2024-02-07_18-42-49.mp4

Reproduction

1. Create several accounts
2. Go to the account selection page
3. Start deselecting accounts one by one

Actual behavior

Error occurs and the app freezes

Logs

Status-debug-logs (85).zip

Additional Information

• Status version: [WIP] Enable account selection feature flag #18530
• Operating System: Android, iOS

[Parveshdhull]

Hi @qoqobolo, Thank you very much for finding this issue.

Error occurs when we deselect account which makes us eligible for joining.
I fixed the bug and error don't occur anymore.

But even if there is no error, app is in weird state at the time. Please can you check out pr and let me know what should be the expected behavior. Is no error enough?

(Also please can you share designs related to these files. Thank you)

[Parveshdhull]

pr #18759

[qoqobolo]

Error occurs when we deselect account which makes us eligible for joining.

Oh interesting, that was my first thought but I failed to reproduce it this way for some reason.
Thanks for making it clear and for the fix @Parveshdhull !

But even if there is no error, app is in weird state at the time

Could you elaborate please on what you mean by weird state?
This missing icon?

Also please can you share designs related to these files

Sure, here it is
https://www.figma.com/file/h9wo4GipgZURbqqr1vShFN/Communities-for-Mobile?type=design&node-id=15331-288058&mode=design&t=wQ3Qe2ZFSVFQCUFD-4

[Parveshdhull]

Hi, Thank you very much for designs, by weird state I mean (Once we deselect account with required token)

1. In Addresses for permissions screen, should we keep showing Eligible to join as Member or hide it, or instead display You are not eligible anymore.
2. In Request to join screen there are no indicator about eligibility but Slide to request to join is still enabled. Should we disable it?
3. Once we deselect required account, overview screen just shows You are not eligible to join and don't let accounts to be selected again. Until community reopened.

Maybe they only looks confusing to me, or they are still in under development. Please let me know if removal of error is enough? In that case PR is ready :)

[Parveshdhull]

Oh interesting, that was my first thought but I failed to reproduce it this way for some reason.

Yes, also in my case sometime error only logged in metro without any crashes or freezing.

[Parveshdhull]

1. In Addresses for permissions screen, should we keep showing Eligible to join as Member or hide it, or instead display You are not eligible anymore.

Ok, in this case we should display These addresses don’t contain tokens needed to join (ref)

[Parveshdhull]

And disables confirm button. Cool I will disable this button and this will solve other 2 issues.

[qoqobolo]

Cool I will disable this button and this will solve other 2 issues.

Thank you very much @Parveshdhull!
Yes the account selection feature is still under development, and it will be a great help from your side to the Ledger Drops crew who is working hard on it!
We've just started testing the branch and there is still a lot of work to be done