Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token icons are not fetched in token gated communities' requirements description #17873

Closed
pavloburykh opened this issue Nov 10, 2023 · 7 comments · Fixed by #18174
Closed

Token icons are not fetched in token gated communities' requirements description #17873

pavloburykh opened this issue Nov 10, 2023 · 7 comments · Fixed by #18174

Comments

@pavloburykh
Copy link
Contributor

pavloburykh commented Nov 10, 2023

Followup of #17799 cc @ilmotta

Steps:

  1. Open token gated community screen
  2. Pay attention if token icon is fetched for token value requirement

Actual result: token icons are not fetched

photo_2023-11-10 14 19 05

Expected result: token icons are fetched

Communities for Mobile – Figma 2023-11-10 14-16-25

Additional Information

  • Status version: nightly
  • Operating System: Android, iOS
@mohsen-ghafouri
Copy link
Contributor

to resolve this issue in need token list that will be done here #17965, i will continue working on it after they merged it

@ilmotta
Copy link
Contributor

ilmotta commented Nov 22, 2023

@mohsen-ghafouri, there's nobody assigned to #17965, so maybe if we really want to fix the token icons bug we should also pick 17965 and not wait.

@J-Son89 do you know if #17965 will be picked up soon? Or perhaps that's not a priority for the wallet team?

@J-Son89
Copy link
Contributor

J-Son89 commented Nov 22, 2023

Someone from wallet can take it unless @mohsen-ghafouri has capacity to take it now? No problem for either way 👍

@mohsen-ghafouri
Copy link
Contributor

@ilmotta @J-Son89 i'm currently working on this issue #17909 , if no body pick that one i will be happy to work on it. hopefully i can finish my current task by tomorrow

@ulisesmac
Copy link
Contributor

@ilmotta @mohsen-ghafouri I already took that issue 👍

@ulisesmac
Copy link
Contributor

@mohsen-ghafouri

PR done: #18018

@ulisesmac
Copy link
Contributor

@mohsen-ghafouri I'm taking this issue since I was involved in a very close solution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants