Permissions are still not requested during profile photo setting (Android)

[pavloburykh]

This one is related and should be fixed is scope of RN upgrade PR #17241

Reproducing on Android 12, Samsung Galaxy A52

Preconditions: media permissions are not granted

Steps:

1. Proceed to "Create profile" onboarding step
2. Open gallery to set up profile photo
3. See if permission pop up appeared when opening gallery

Actual result: permissions are not requested. Gallery is opened all the images are available for selection. User can set up gallery image as profile photo.

telegram-cloud-document-2-5355054534202769532.mp4

Expected result: permissions should be requested. User should not have access to gallery images until permissions are granted.

Additional Information

• Status version: RN upgrade PR build PR to upgrade react-native to 0.72.5 and many other things #17241
• Operating System: Android

[siddarthkay]

Logging my findings below,

In case of profile picture we rely on react-native-image-crop-picker library to show us a native image picker with cropping capabilities ref : https://github.com/ivpusic/react-native-image-crop-picker
In case of showing image picker from chat screen we rely on react-native-cameraroll library ref : https://github.com/react-native-cameraroll/react-native-cameraroll

In case of react-native-cameraroll (used in chatview) we explicitly ask for user permissions before invoking any of the camera/gallery related functions, however in case of react-native-image-crop-picker we don't.

There would be good reasons for having 2 separate libraries for this purpose in the past I assume.

[siddarthkay]

Explicitly asking for media permissions for consistent behaviour here : fe7d021

@pavloburykh I verified this on 2 android emulators, API 29 and 33.

Could you pls verify?
Thank you.

[pavloburykh]

Could you pls verify?

Hi @siddarthkay! Quickly checked, the issue is gone for me. Thank you!
Currently we are busy with release testing, will be able to continue more deeply testing after we finish with the release.

[siddarthkay]

Thanks for checking @pavloburykh !

we are busy with release testing, will be able to continue more deeply testing after we finish with the release.

Awesome! Sure, take your time :)

[siddarthkay]

fixed here : #17241