Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design feedback for bottom sheet in 1:1 chat #17539

Closed
2 tasks
BalogunofAfrica opened this issue Oct 4, 2023 · 3 comments
Closed
2 tasks

Design feedback for bottom sheet in 1:1 chat #17539

BalogunofAfrica opened this issue Oct 4, 2023 · 3 comments
Assignees
@BalogunofAfrica
Labels
high-prio
Milestone
2.27.0 Alpha

Comments

@BalogunofAfrica
Copy link
Contributor

BalogunofAfrica commented Oct 4, 2023 •
edited
Loading

Bug Report

  • Wrong icon for muting chat
  • There is no divider for items in message list in sheet after the add nickname action

Design review here: https://www.figma.com/file/Tf5nfkYvpbnNCo4rKLK7lS?node-id=6142:39869&mode=design#570508962
@BalogunofAfrica BalogunofAfrica changed the title wrong icon for muting chat feedback for message list in 1:1 chat Oct 7, 2023
@churik churik changed the title feedback for message list in 1:1 chat Design feedback for bottom sheet in 1:1 chat Oct 23, 2023
@BalogunofAfrica BalogunofAfrica self-assigned this Oct 26, 2023
@BalogunofAfrica
Copy link
Contributor Author

This would also include the design change for the context drawer found here

https://www.figma.com/file/7KIYbhoqNGAIFonE0w9TDz/Messages-for-Mobile?type=design&node-id=1447-349773&mode=design&t=FDnIxT7oYquTrHmz-0

@BalogunofAfrica
Copy link
Contributor Author

Based on the design change above, the destructive action for deleting chat would change to a simple close which just removes the chat from the chat list under messages

@BalogunofAfrica BalogunofAfrica mentioned this issue Nov 2, 2023
Merged
@BalogunofAfrica BalogunofAfrica added this to the 1.26.0 - Alpha milestone Nov 15, 2023
@churik churik modified the milestones: 1.26.0 - Alpha, 1.27.0 - Alpha Nov 27, 2023
@churik churik added high-prio and removed low-prio labels Dec 6, 2023
@BalogunofAfrica
Copy link
Contributor Author

Closed by #17795

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BalogunofAfrica BalogunofAfrica

Labels
high-prio
Projects
None yet
Milestone
2.27.0 Alpha
Development

No branches or pull requests
2 participants
@churik @BalogunofAfrica