Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quo 2 - Update Drawers / Bottom Actions component to adapt the new design #15006

Closed
J-Son89 opened this issue Feb 7, 2023 · 1 comment · Fixed by #18513
Closed

Quo 2 - Update Drawers / Bottom Actions component to adapt the new design #15006

J-Son89 opened this issue Feb 7, 2023 · 1 comment · Fixed by #18513
Assignees
@ajayesivan
Labels
design-system

Comments

@J-Son89
Copy link
Contributor

J-Son89 commented Feb 7, 2023 •
edited by ajayesivan
Loading

Update this component in the quo2 component library as per the design spec:

Designs - Drawers / Bottom Actions
https://www.figma.com/file/WQZcp6S0EnzxdTL4taoKDv/Design-System-for-Mobile?node-id=2638%3A35963&t=29WaMjPTYMtHqa1n-0

** There is an implementation of this more or less done in https://github.com/status-im/status-mobile/blob/develop/src/status_im2/contexts/communities/menus/request_to_join/view.cljs#L112-L132

Acceptance Criteria

  • dark and light mode
  • component tests (jest)
  • quo2 preview
  • export from quo2/core.cljs
  • adjust usage in communities join screen to use this component
@J-Son89 J-Son89 added the feature feature requests label Feb 7, 2023
@J-Son89 J-Son89 mentioned this issue Feb 7, 2023
Closed
@J-Son89 J-Son89 mentioned this issue Jul 24, 2023
Merged
@ajayesivan ajayesivan self-assigned this Jan 2, 2024
@ajayesivan
Copy link
Contributor

This component already exists but the design was updated, some changes where added in this version. The updated version is required for the new join community flow.

@ajayesivan ajayesivan changed the title Quo 2 - Implement Drawers / Bottom Actions component Quo 2 - Update Drawers / Bottom Actions component to adapt the new design Jan 2, 2024
@ajayesivan ajayesivan mentioned this issue Jan 4, 2024
Merged
@ajayesivan ajayesivan removed the feature feature requests label Jan 4, 2024
@ajayesivan ajayesivan mentioned this issue Jan 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajayesivan ajayesivan

Labels
design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update drawer/bottom-actions component status-im/status-mobile
3 participants
@cammellos @ajayesivan @J-Son89