Skip to content

Commit

Permalink
js: remove unused visual tests and detox package #16372
Browse files Browse the repository at this point in the history
After the nixpkgs upgrade we started to have Xcode command line tools installation popup on each make test, dtrace-provider was failing meanwhile: #16356

It appeared, that it was failing before the upgrade with different issue: #16356

dtrace-provider is a dependency for detox, which was added for visiual tests in #14329
These tests don't run.

This build issues didn't cause any problems, because it was not obligatary.
See NODE_DTRACE_PROVIDER_REQUIRE option, which can enforce this requirement.

See #16356 for more details.

In this PR we disable detox dependency for now.
And also Visual Tests.
  • Loading branch information
yakimant committed Jun 26, 2023
1 parent 6f0d375 commit 43ef6db
Show file tree
Hide file tree
Showing 9 changed files with 8 additions and 494 deletions.
37 changes: 0 additions & 37 deletions .detoxrc.js

This file was deleted.

8 changes: 0 additions & 8 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -343,14 +343,6 @@ test: ##@test Run tests once in NodeJS
yarn shadow-cljs compile test && \
node --require ./test-resources/override.js target/test/test.js


run-visual-test-ios: export TARGET := clojure
run-visual-test-ios: XCODE_DERIVED_DATA := $(HOME)/Library/Developer/Xcode/DerivedData
run-visual-test-ios: APPLICATION_NAME := StatusIm-brfnruzfrkkycpbndmdoeyrigthc
run-visual-test-ios: export TEST_BINARY_PATH := $(XCODE_DERIVED_DATA)/$(APPLICATION_NAME)/Build/Products/Debug-iphonesimulator/StatusIm.app
run-visual-test-ios: ##@test Run tests once in NodeJS
detox test --configuration ios.sim.debug

component-test-watch: export TARGET := clojure
component-test-watch: export COMPONENT_TEST := true
component-test-watch: export BABEL_ENV := test
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,6 @@
"@testing-library/react-native": "^11.2.0",
"@types/jest": "^28.1.6",
"concurrently": "^7.6.0",
"detox": "^19.9.1",
"jest": "^26.6.3",
"jest-circus": "^26.0.0",
"jest-image-snapshot": "^5.1.0",
Expand Down
14 changes: 0 additions & 14 deletions visual-test/config.json

This file was deleted.

19 changes: 0 additions & 19 deletions visual-test/environment.js

This file was deleted.

40 changes: 0 additions & 40 deletions visual-test/global-setup.js

This file was deleted.

7 changes: 0 additions & 7 deletions visual-test/global-teardown.js

This file was deleted.

40 changes: 0 additions & 40 deletions visual-test/setup.js

This file was deleted.

Loading

0 comments on commit 43ef6db

Please sign in to comment.