Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rln-Relay: Persisting rln credentials #1021

Closed
staheri14 opened this issue Jun 23, 2022 · 5 comments
Closed

Rln-Relay: Persisting rln credentials #1021

staheri14 opened this issue Jun 23, 2022 · 5 comments
Labels
track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications

Comments

@staheri14
Copy link
Contributor

staheri14 commented Jun 23, 2022

In the dynamic/onchain mode of waku rln relay, generated rln credentials are not being persisted. As such, the wakunode create, registers, and uses a new set of credentials for each run. While this does not cause a serious problem during dogfooding on a testnet, it causes fund loss due to unnecessary re-registration to the group.
This issue is to implement necessary mechanism to properly persist and resue rln credetnials across multiple runs.

@kgrgpg kgrgpg self-assigned this Jun 30, 2022
@kgrgpg
Copy link
Contributor

kgrgpg commented Jul 20, 2022

@staheri14 You can track the pull request associated with this issue here:
#1037

@oskarth oskarth added the track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications label Jul 25, 2022
@staheri14
Copy link
Contributor Author

staheri14 commented Aug 15, 2022

The nimbus key-store is a potential solution for this problem.
Might be useful to have a look at https://github.com/status-im/nimbus-eth2/blob/88532c61772ed8c065fe7ab2e9204a8c40de4656/tests/test_keystore_management.nim

@LNSD LNSD self-assigned this Aug 22, 2022
@LNSD
Copy link
Contributor

LNSD commented Aug 22, 2022

As @staheri14 has pointed out, the idea is to use the same Keystore implementation as nimbus uses.

At first, seems that depends on nimbus-specific types (e.g., beacon_chain/spec/datatypes/base). Some of those types might be interesting to port also into nwaku codebase.

Added to that, I foresee that @s1fr0 review will be very valuable during this code porting/integration.

@arnetheduck
Copy link
Contributor

Of (design) interest here might be clef - that said, it would indeed be good to keep key management coherent within our suite of apps - exporting the keystore from nimbus is certainly possible cc @zah

@s1fr0
Copy link
Contributor

s1fr0 commented Oct 28, 2022

With the implementation of Web3 Secure Storage keyfiles, merged with #1285, this issue can be closed.

@s1fr0 s1fr0 closed this as completed Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications
Projects
None yet
Development

No branches or pull requests

6 participants