From 90910f6f0467bea847593d5d853d1cf0884abe4c Mon Sep 17 00:00:00 2001 From: tersec Date: Sat, 22 Apr 2023 10:58:05 +0000 Subject: [PATCH] remove references to Nim issue decided effectively as WONTFIX --- beacon_chain/conf.nim | 1 - beacon_chain/consensus_object_pools/consensus_manager.nim | 1 - beacon_chain/gossip_processing/block_processor.nim | 1 - 3 files changed, 3 deletions(-) diff --git a/beacon_chain/conf.nim b/beacon_chain/conf.nim index c9c3877396..a1c0af1037 100644 --- a/beacon_chain/conf.nim +++ b/beacon_chain/conf.nim @@ -1298,7 +1298,6 @@ func defaultFeeRecipient*(conf: AnyConf): Eth1Address = if conf.suggestedFeeRecipient.isSome: conf.suggestedFeeRecipient.get else: - # https://github.com/nim-lang/Nim/issues/19802 (static(default(Eth1Address))) proc loadJwtSecret*( diff --git a/beacon_chain/consensus_object_pools/consensus_manager.nim b/beacon_chain/consensus_object_pools/consensus_manager.nim index 88cdcbc3c5..a78ab0b3c9 100644 --- a/beacon_chain/consensus_object_pools/consensus_manager.nim +++ b/beacon_chain/consensus_object_pools/consensus_manager.nim @@ -213,7 +213,6 @@ func getKnownValidatorsForBlsChangeTracking( else: # It is not possible for any BLS to execution changes, for any validator, # to have been yet processed. - # https://github.com/nim-lang/Nim/issues/19802 (static(@[])) proc updateHead*(self: var ConsensusManager, newHead: BlockRef) = diff --git a/beacon_chain/gossip_processing/block_processor.nim b/beacon_chain/gossip_processing/block_processor.nim index b8f2980ce0..9a6d11b69f 100644 --- a/beacon_chain/gossip_processing/block_processor.nim +++ b/beacon_chain/gossip_processing/block_processor.nim @@ -235,7 +235,6 @@ proc expectValidForkchoiceUpdated( when typeof(receivedBlock).toFork >= ConsensusFork.Bellatrix: receivedBlock.message.body.execution_payload.block_hash else: - # https://github.com/nim-lang/Nim/issues/19802 (static(default(Eth2Digest))) # Only called when expecting this to be valid because `newPayload` or some