Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Routing table metrics issues #503

Open
kdeme opened this issue Apr 14, 2022 · 0 comments
Open

Routing table metrics issues #503

kdeme opened this issue Apr 14, 2022 · 0 comments
Labels
discoveryv5 Discovery v5 related issues

Comments

@kdeme
Copy link
Contributor

kdeme commented Apr 14, 2022

Two bugs / issues related to the routing_table_nodes metric of routing_table.nim:

  • The counting with seen label is off. TBI
  • Routing table can be used by several protocols with DHT, and thus instantiated multiple times, however the counting will all sum up. Probably have to add some identifier to the routing table object and use that in a label.

Additionally the current way the state label is used is probably confusing (all nodes vs seen nodes)
@kdeme kdeme added the discoveryv5 Discovery v5 related issues label Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discoveryv5 Discovery v5 related issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kdeme