chore: disable sqlite store on wakuv2.prod
#53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaiserd
approved these changes
Jun 23, 2022
|
One not though. You added a nice explanation as to why you want this change in the PR description, but not in the commit. I think this kind of info should also be included in the commit for the sake of easy access to history. Fixed it: e563b766 |
|
Deployed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a known issue in v0.10 where certain store queries can slow down nodes: waku-org/nwaku#1017
A possible (at least partial) fix has been merged (waku-org/nwaku#1018) and deployed to
wakuv2.test, but the SQLite store can be disable onprodin the meantime.cc @kaiserd in case you'd rather have us keep this enabled but, say, with a shorter retention time. I think safest is to disable.