Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add certora CI integration #24

Merged
merged 1 commit into from
Dec 14, 2023
Merged

feat: add certora CI integration #24

merged 1 commit into from
Dec 14, 2023

Conversation

0x-r4bbit
Copy link
Member

This backports Certora CI integration to this repository, resulting in GitHub Actions being extended to run formal verification on any change to contracts that comes in via pull requests.

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • Added natspec comments?
  • Ran forge snapshot?
  • Ran pnpm lint?
  • Ran forge test?
  • Ran pnpm verify?

@0x-r4bbit
Copy link
Member Author

@gravityblast this reactivates your original rules for formal verification on CollectibleV1.
It seems the prover found a bug here, or the rule needs to be adjusted.

PTAL.

This backports Certora CI integration to this repository, resulting in
GitHub Actions being extended to run formal verification on any change
to contracts that comes in via pull requests.
@0x-r4bbit
Copy link
Member Author

@gravityblast I've updated this PR and commented out all of the legacy rules for now so we get the certora integration.

If you're good with that, I'm gonna merge this.

@0x-r4bbit 0x-r4bbit merged commit 8773220 into main Dec 14, 2023
7 checks passed
@0x-r4bbit 0x-r4bbit deleted the feat/ci-certora branch December 14, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants