Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: move code out of main package #141

Merged
merged 2 commits into from
Jan 26, 2023
Merged

Conversation

erikgb
Copy link
Member

@erikgb erikgb commented Jan 26, 2023

This moves most of the bootstrapping code out of the main package. To be able to use the operator package name, I had to move the Config struct to a new package - to avoid circular dependencies.

Close #81

BREAKING CHANGE: This moves the Config struct to a new package located under internal (no longer available to consumers).

@erikgb erikgb requested a review from a team as a code owner January 26, 2023 09:30
Copy link
Contributor

@mikaelol mikaelol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. LGTM.

@erikgb erikgb changed the title refactor: move code out of main package refactor!: move code out of main package Jan 26, 2023
Copy link
Contributor

@padlar padlar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@erikgb erikgb merged commit b495881 into statnett:main Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor main.go
3 participants