feat(admin)!: kustomizeable configmap for scan job default configuration #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikgb
changed the title
erikgb
force-pushed
the
scan-job-configmap
branch
from
22d7d0b to
c9caa1e
Compare
erikgb
force-pushed
the
scan-job-configmap
branch
4 times, most recently
from
5faf819 to
baca084
Compare
bendikp
reviewed
Jan 23, 2023
bendikp
previously approved these changes
Jan 23, 2023
erikgb
force-pushed
the
scan-job-configmap
branch
2 times, most recently
from
18dde21 to
30918e2
Compare
erikgb
force-pushed
the
scan-job-configmap
branch
from
30918e2 to
14e22df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #109
BREAKING CHANGE: This moves the configuration of Trivy server from the operator configmap to the new configmap for scan jobs. Any admins overriding the default value will is required to update their configuration.