Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posterior values always zero or one #66

Open
ccrobertson opened this issue May 6, 2023 · 3 comments
Open

Posterior values always zero or one #66

ccrobertson opened this issue May 6, 2023 · 3 comments

Comments

@ccrobertson
Copy link

When I run demuxlet, I get the following:

SNG.POSTERIOR is always equal to 1 (even with DROPLET.TYPE==DBL)
BEST.POSTERIOR is always a negative number

From reading other github issues, it looks like the negative values for BEST.POSTERIOR is a bug, and the posterior probability of the best guess is actually PP = e^BEST.POSTERIOR. But even when I do this transformation, this results in

PP=1 for all barcodes with DROPLET.TYPE==DBL
PP=0 for all barcodes with DROPLET.TYPE==SNG

Has anyone else seen this?

@hyunminkang
Copy link
Contributor

There is a bug in the current calculation of BEST.POSTERIOR. The bug affects doublets and singlets differently, so probably not useful to rely on it until the bug is fixed. I usually prefer using DIFF.LLK.BEST.NEXT to see how strong the evidence of current inference is.

@ccrobertson
Copy link
Author

Thanks! That is really helpful.

By chance, do you know if this bug is relevant to the original demuxlet repository (https://github.com/statgen/demuxlet)? I know there are folks in our group using both versions.

@tfguinan
Copy link

tfguinan commented Aug 1, 2023

Hi, we've come across this too (albeit alongside troubleshooting high doublets; and in apptainer), just wondering if anyone has identified a previous commit in either repo without the calculation bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants