Skip to content
This repository has been archived by the owner on Oct 7, 2022. It is now read-only.

[monorepo] ESLint consolidation #652

Closed
Alonski opened this issue Dec 5, 2019 · 2 comments
Closed

[monorepo] ESLint consolidation #652

Alonski opened this issue Dec 5, 2019 · 2 comments

Comments

@Alonski
Copy link
Contributor

Alonski commented Dec 5, 2019

In #611 there was a fair bit of discussion surround various ESLint settings and configurations.

To unblock the merging of that PR I am moving the discussion to here.

Things to discuss:

  1. @snario Many of the rules in .eslintignore overlap with (a) .gitignore regexes and (b) other .eslintignore in other packages. Can we consolidate?

  2. @snario Many of the rules in package eslintrc.js seem to be duplicates of rules in other packages. Can we consolidate them in root .eslintrc.js file please?

  3. @snario I would be careful with eslint --cache option. When testing a branch I noticed it caused issues when deleting built contract artifacts, running the linter, and then rebuilding them, and running it again. The linter would fail despite the contract artifacts existing.

Lets discuss these things here.

@snario
Copy link
Contributor

snario commented Dec 9, 2019

#686

@snario
Copy link
Contributor

snario commented May 21, 2020

Did this earlier, we have a root eslint which others can inherit now.

@snario snario closed this as completed May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants