Skip to content
This repository has been archived by the owner on Oct 7, 2022. It is now read-only.

[wallet] Dynamically fetch ConsensusApp bytecode from the chain on wallet start #524

Closed
snario opened this issue Nov 21, 2019 · 4 comments
Closed

Comments

@snario
Copy link
Contributor

snario commented Nov 21, 2019

As of #519, the bytecode for ConsensusApp is loaded as a constant in constants.ts. It is preferable to auto-fetch this from the blockchain when the wallet first starts.

@andrewgordstewart
Copy link
Contributor

It's probably safe to punt this, since I think we're just going to axe the ConsensusApp.

@snario
Copy link
Contributor Author

snario commented Nov 21, 2019

@andrewgordstewart going to use 0x0 for appDefinition?

@andrewgordstewart
Copy link
Contributor

andrewgordstewart commented Nov 21, 2019

I think so, in which case the wallet doesn't need to call validTransition (because there are no valid transitions).

There may still be value in calling a function

thesebytesAreIndeedAState(bytes calldata maybeAState) public pure {
  abi.decode(state, State); 
}

in lieu of calling validTransition(s1, s2). But we might be content to call a javascript implementation of abi.decode from ethers, for instance.

@lalexgap
Copy link
Contributor

lalexgap commented Apr 7, 2020

Refers to the old wallet

@lalexgap lalexgap closed this as completed Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants