Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration tests for detecting and responding to a Challenge #1615

Open
geoknee opened this issue Aug 30, 2023 · 2 comments
Open

Add integration tests for detecting and responding to a Challenge #1615

geoknee opened this issue Aug 30, 2023 · 2 comments

Comments

@geoknee
Copy link
Contributor

geoknee commented Aug 30, 2023 

          > This LGTM, but wanting for a follow-up with tests that consume the same.

I added a test here add estUpdateWithChallengeRegisteredEvent but as you say it doesn't cover that much code at present. Be nice to get an integration test going with a chain and engine and then we could assert on some notification perhaps?

Originally posted by @geoknee in #1593 (comment)
@lalexgap
Copy link
Contributor

#1593 (comment)

@geoknee
Copy link
Contributor Author

geoknee commented Aug 31, 2023

#1618

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lalexgap @geoknee