-
-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw a helpful exception if a referenced blueprint does not exist #3977
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we call it BlueprintNotFoundException
? We use the "not found" pattern all over. You even use it in the message. 😄
One step ahead of you, see dd72ea2. |
I don't know how helpful the suggestions are. I renamed a blueprint in order to see the error. Then I get this, which is probably even more confusing. If we want to provide suggestions, maybe we should pass in the namespace so it only suggests ones that would work. |
It's an easy fix, I'll just do it 👍 |
This pull request adds a helpful exception that'll be thrown if a specified blueprint does not exist. I've added an Ignition solution to the exception that'll suggest any blueprints close ish to the specified one (done the same way as in the
CollectionNotFoundException
)Closes #3920
Ignition Exception