Smarten up conditions on Entry fields

[duncanmcclean]

This pull request closes #3954. The examples explain the fix (which I shamelessly stole from Jack's issue 😆 )

Examples

Before

post: 123-123-123-1234
---
{{ collection:products :post:is="post" }} // this doesn't work
{{ collection:products :post:is="post:id" }} // this does work but it's not intuitive

After

post: 123-123-123-1234
---
{{ collection:products :post:is="post" }} // NOW this works
{{ collection:products :post:is="post:id" }} // of course, this stays working

---

I did originally write the code to do this for terms too but I was too lazy to get everything around that setup to make sure it works. It's pretty much the same as the Entry code I added but for the Term interface. I can add it back if you want.

[jasonvarga]

Would you mind whipping up a repo that shows how it's broken before this change?

It seems to work fine when I tried. I must be missing something specific.

[duncanmcclean]

Would you mind whipping up a repo that shows how it's broken before this change?

It seems to work fine when I tried. I must be missing something specific.

Sure, will do!

[duncanmcclean]

Here we go - https://github.com/duncanmcclean/cms-3976

My home entry has an entries field to itself
My article entries have an entries field, two of them point to the home entry

When pulled in with this branch, the results from both examples should be the same (you can replicate when viewing the homepage)

[jasonvarga]

Thanks for the repo and the PR. 👍

I'm going to close this PR for now though.

This PR would change the behavior of this existing behavior: d6b1d21

I agree that being able to do {{ collection:products :post:is="post" }} makes a lot of sense, but this change could potentially break things.

[jasonvarga]

Added more context here. #3954 (comment)